diff --git a/modules/browser_object_autofill_popup.py b/modules/browser_object_autofill_popup.py index b0bbe5380..a4c79d9e4 100644 --- a/modules/browser_object_autofill_popup.py +++ b/modules/browser_object_autofill_popup.py @@ -141,5 +141,6 @@ def verify_update_password_doorhanger(self, nav, expected_text): # Verify the doorhanger text self.expect( - lambda _: expected_text in self.get_element("password-update-doorhanger").text + lambda _: expected_text + in self.get_element("password-update-doorhanger").text ) diff --git a/modules/page_object_autofill.py b/modules/page_object_autofill.py index 3c0b88f37..3d85c152f 100644 --- a/modules/page_object_autofill.py +++ b/modules/page_object_autofill.py @@ -860,8 +860,8 @@ def generate_secure_password(self, context_menu): # Wait until the password field is actually filled self.parent.expect( lambda _: ( - (elem := self.parent.get_element("password-login-field")) - and elem.get_attribute("value") not in ("", None) + (elem := self.parent.get_element("password-login-field")) + and elem.get_attribute("value") not in ("", None) ) ) diff --git a/tests/address_bar_and_search/test_addon_suggestion.py b/tests/address_bar_and_search/test_addon_suggestion.py index b77f69649..888ed0b6f 100644 --- a/tests/address_bar_and_search/test_addon_suggestion.py +++ b/tests/address_bar_and_search/test_addon_suggestion.py @@ -6,17 +6,16 @@ from modules.browser_object import Navigation -WAIT_TIMEOUT = 10 ADDONS_BASE_URL = "https://addons.mozilla.org/en-US/firefox/addon/" +# pending answers from search team about FX changes here, only grammar works as before INPUT_TO_ADDON_NAME = { - "clips": "video-downloadhelper", + "video download": "video-downloadhelper", "grammar": "languagetool", - "Temp mail": "private-relay", - "pics search": "search_by_image", + "alias": "private-relay", + "image finder": "search_by_image", "darker theme": "darkreader", - "privacy": "privacy-badger17", - "read aloud": "read-aloud", + "accessibility reade": "read-aloud", } @@ -28,7 +27,7 @@ def test_case(): @pytest.mark.noxvfb def test_addon_suggestion_based_on_search_input(driver: Firefox): """ - C2234714 - Verify that the address bar suggests relevant add-ons based on search input. + C3029292 - Verify that the address bar suggests relevant add-ons based on search input. """ nav = Navigation(driver) nav.set_awesome_bar() diff --git a/tests/password_manager/test_auto_saved_generated_password_context_menu.py b/tests/password_manager/test_auto_saved_generated_password_context_menu.py index 78bfecdc8..f1a6a17b7 100644 --- a/tests/password_manager/test_auto_saved_generated_password_context_menu.py +++ b/tests/password_manager/test_auto_saved_generated_password_context_menu.py @@ -36,9 +36,7 @@ def test_auto_saved_generated_password_context_menu(driver: Firefox): login_autofill.LoginForm(login_autofill).generate_secure_password(context_menu) # Verify the update doorhanger is displayed - autofill_popup_panel.verify_update_password_doorhanger( - nav, UPDATE_DOORHANGER_TEXT - ) + autofill_popup_panel.verify_update_password_doorhanger(nav, UPDATE_DOORHANGER_TEXT) # Navigate to about:logins page tabs.switch_to_new_tab()