From aaa74561fa75ddd3bd71eaa3ebd4f7f9c423947e Mon Sep 17 00:00:00 2001 From: soncuteanca Date: Thu, 13 Nov 2025 15:41:29 +0200 Subject: [PATCH 1/3] Fix addon-suggestion --- modules/browser_object_autofill_popup.py | 3 ++- modules/page_object_autofill.py | 4 ++-- .../test_addon_suggestion.py | 17 +++++++++-------- ...uto_saved_generated_password_context_menu.py | 4 +--- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/modules/browser_object_autofill_popup.py b/modules/browser_object_autofill_popup.py index b0bbe5380..a4c79d9e4 100644 --- a/modules/browser_object_autofill_popup.py +++ b/modules/browser_object_autofill_popup.py @@ -141,5 +141,6 @@ def verify_update_password_doorhanger(self, nav, expected_text): # Verify the doorhanger text self.expect( - lambda _: expected_text in self.get_element("password-update-doorhanger").text + lambda _: expected_text + in self.get_element("password-update-doorhanger").text ) diff --git a/modules/page_object_autofill.py b/modules/page_object_autofill.py index 3c0b88f37..3d85c152f 100644 --- a/modules/page_object_autofill.py +++ b/modules/page_object_autofill.py @@ -860,8 +860,8 @@ def generate_secure_password(self, context_menu): # Wait until the password field is actually filled self.parent.expect( lambda _: ( - (elem := self.parent.get_element("password-login-field")) - and elem.get_attribute("value") not in ("", None) + (elem := self.parent.get_element("password-login-field")) + and elem.get_attribute("value") not in ("", None) ) ) diff --git a/tests/address_bar_and_search/test_addon_suggestion.py b/tests/address_bar_and_search/test_addon_suggestion.py index b77f69649..cbe76f134 100644 --- a/tests/address_bar_and_search/test_addon_suggestion.py +++ b/tests/address_bar_and_search/test_addon_suggestion.py @@ -9,14 +9,15 @@ WAIT_TIMEOUT = 10 ADDONS_BASE_URL = "https://addons.mozilla.org/en-US/firefox/addon/" +# pending answers from search team about FX changes here, only grammar works as before INPUT_TO_ADDON_NAME = { - "clips": "video-downloadhelper", + # "clips": "video-downloadhelper", "grammar": "languagetool", - "Temp mail": "private-relay", - "pics search": "search_by_image", - "darker theme": "darkreader", - "privacy": "privacy-badger17", - "read aloud": "read-aloud", + # "Temp mail": "private-relay", + # "pics search": "search_by_image", + # "darker theme": "darkreader", + # "privacy": "privacy-badger17", + # "read aloud": "read-aloud", } @@ -28,12 +29,12 @@ def test_case(): @pytest.mark.noxvfb def test_addon_suggestion_based_on_search_input(driver: Firefox): """ - C2234714 - Verify that the address bar suggests relevant add-ons based on search input. + C3029292 - Verify that the address bar suggests relevant add-ons based on search input. """ nav = Navigation(driver) nav.set_awesome_bar() - sleep(3) # Wait for Firefox to do backend addons initiation + sleep(10) # Wait for Firefox to do backend addons initiation for input_text, addon_slug in INPUT_TO_ADDON_NAME.items(): nav.type_in_awesome_bar(input_text) diff --git a/tests/password_manager/test_auto_saved_generated_password_context_menu.py b/tests/password_manager/test_auto_saved_generated_password_context_menu.py index 78bfecdc8..f1a6a17b7 100644 --- a/tests/password_manager/test_auto_saved_generated_password_context_menu.py +++ b/tests/password_manager/test_auto_saved_generated_password_context_menu.py @@ -36,9 +36,7 @@ def test_auto_saved_generated_password_context_menu(driver: Firefox): login_autofill.LoginForm(login_autofill).generate_secure_password(context_menu) # Verify the update doorhanger is displayed - autofill_popup_panel.verify_update_password_doorhanger( - nav, UPDATE_DOORHANGER_TEXT - ) + autofill_popup_panel.verify_update_password_doorhanger(nav, UPDATE_DOORHANGER_TEXT) # Navigate to about:logins page tabs.switch_to_new_tab() From 53688c0de83111d6451469fcd9311b666cc569d5 Mon Sep 17 00:00:00 2001 From: soncuteanca Date: Fri, 14 Nov 2025 17:33:14 +0200 Subject: [PATCH 2/3] Update list --- .../address_bar_and_search/test_addon_suggestion.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/address_bar_and_search/test_addon_suggestion.py b/tests/address_bar_and_search/test_addon_suggestion.py index cbe76f134..696c9d56b 100644 --- a/tests/address_bar_and_search/test_addon_suggestion.py +++ b/tests/address_bar_and_search/test_addon_suggestion.py @@ -6,18 +6,16 @@ from modules.browser_object import Navigation -WAIT_TIMEOUT = 10 ADDONS_BASE_URL = "https://addons.mozilla.org/en-US/firefox/addon/" # pending answers from search team about FX changes here, only grammar works as before INPUT_TO_ADDON_NAME = { - # "clips": "video-downloadhelper", + "video download": "video-downloadhelper", "grammar": "languagetool", - # "Temp mail": "private-relay", - # "pics search": "search_by_image", - # "darker theme": "darkreader", - # "privacy": "privacy-badger17", - # "read aloud": "read-aloud", + "alias": "private-relay", + "image finder": "search_by_image", + "darker theme": "darkreader", + "accessibility reade": "read-aloud", } From 36e4cdb004f4fcd8becc9ae7628391a32c638a24 Mon Sep 17 00:00:00 2001 From: soncuteanca Date: Fri, 14 Nov 2025 17:36:49 +0200 Subject: [PATCH 3/3] Reduce the wait time --- tests/address_bar_and_search/test_addon_suggestion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/address_bar_and_search/test_addon_suggestion.py b/tests/address_bar_and_search/test_addon_suggestion.py index 696c9d56b..888ed0b6f 100644 --- a/tests/address_bar_and_search/test_addon_suggestion.py +++ b/tests/address_bar_and_search/test_addon_suggestion.py @@ -32,7 +32,7 @@ def test_addon_suggestion_based_on_search_input(driver: Firefox): nav = Navigation(driver) nav.set_awesome_bar() - sleep(10) # Wait for Firefox to do backend addons initiation + sleep(3) # Wait for Firefox to do backend addons initiation for input_text, addon_slug in INPUT_TO_ADDON_NAME.items(): nav.type_in_awesome_bar(input_text)