Skip to content
This repository

Bug #682211 - html selection boxes clipped by panel (share type and autocomplete) #11

Merged
merged 2 commits into from almost 3 years ago

2 participants

James Burke Mark Hammond
James Burke
Collaborator

Repositions the custom HTML simulated select for facebook's shareType choices so that all options are visible. Also updates AutoComplete's use of owasvc.parameters.features to use the right property, subjectLabel, so that if/when gmail is supported, the to: autocomplete will be visible.

Mark Hammond mhammond merged commit 0590121 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 2 unique commits by 1 author.

Sep 21, 2011
James Burke jrburke Fix positioning of share type simulated dropdown for facebook. 7f40f5a
James Burke jrburke Make sure for things that show subject at the top, like gmail, autoco…
…mplete shows below. The features property name has changed, update code to match.
4061913
This page is out of date. Refresh to see the latest.
2  data/ui/scripts/AutoComplete.js
@@ -49,7 +49,7 @@ function ($, object, fn, module, dispatch,
49 49 this.attachedWidget = false;
50 50 this.acOptions = [];
51 51 this.owasvc = owasvc;
52   - this.orient = owasvc.parameters.features.subject ? 'below' : 'above';
  52 + this.orient = owasvc.parameters.features.subjectLabel ? 'below' : 'above';
53 53
54 54 // XXX - still relevant?
55 55 dispatch.sub('optionsChanged', fn.bind(this, function (data) {
6 data/ui/share/scripts/widgets/AccountPanel.html
... ... @@ -1,5 +1,5 @@
1   -<div class="{svc.type} {className}">
2   - <form name="{svc.type}Send" class="hbox messageForm" action="#">
  1 +<div class="{svc.auth.name} {className}">
  2 + <form name="{svc.auth.name}Send" class="hbox messageForm" action="#">
3 3 <div class="user inactive col">
4 4 <input type="hidden" name="userid" value="{profile.userid}" />
5 5 <input type="hidden" name="username" value="{profile.username}" />
@@ -24,7 +24,7 @@
24 24 <input name="subject" placeholder="subject" type="text" value="{options.subject}" autocomplete="off"/>
25 25 {]}
26 26 <textarea class="message compose" placeholder="Type your message here, and we'll attach the link when you send." name="message">{options.message}</textarea>
27   -
  27 +
28 28 <div id="pageInfo">
29 29 <div class="hbox">
30 30 {svc.features.picture [}
4 data/ui/share/style.css
@@ -676,6 +676,10 @@ span.icon.twitter {
676 676 facebook styles
677 677 */
678 678
  679 +.facebook.widgets-AccountPanel .shareTypeSection .Select.open ul {
  680 + top: -40px;
  681 +}
  682 +
679 683 .facebook .facebookActions {
680 684 margin: 0 0 10px 0;
681 685 width: 100%;

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.