Skip to content
This repository has been archived by the owner. It is now read-only.

feat(docker): add docker via Circle CI #212

Merged
merged 2 commits into from Mar 5, 2017
Merged

feat(docker): add docker via Circle CI #212

merged 2 commits into from Mar 5, 2017

Conversation

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Mar 1, 2017

@jbuck
Copy link
Member

@jbuck jbuck commented Mar 1, 2017

@vladikoff added creds, thanks for the reminder!

@seanmonstar
Copy link
Member

@seanmonstar seanmonstar commented Mar 2, 2017

Ah, just tried to push my own branch and enable circle, saw it was already enabled!

Only thing I see here is that since removing the old Dockerfile, the README instructions on using it are incorrect.

@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Mar 2, 2017

@jbuck so for tests to pass we will need a local mysql running I think. Should we use a docker container or something else?

@vladikoff vladikoff force-pushed the docker branch from 8743247 to 4e5c6cc Mar 2, 2017
@jbuck
Copy link
Member

@jbuck jbuck commented Mar 3, 2017

@vladikoff Circle says they have MySQL running locally by default, so all you should need to do is add --net="host" to the docker run command so that the container can connect to it.

@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Mar 3, 2017

@vladikoff Circle says they have MySQL running locally by default, so all you should need to do is add --net="host" to the docker run command so that the container can connect to it.

Sounds good! I'll just need to make sure it is MySql 5.6

@vladikoff vladikoff force-pushed the docker branch from 4e5c6cc to 24c4890 Mar 3, 2017
@vladikoff vladikoff merged commit 8f913be into master Mar 5, 2017
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 94.126%
Details
@vladikoff vladikoff deleted the docker branch Mar 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants