This repository was archived by the owner on Apr 3, 2019. It is now read-only.
feat(mysql): Add config option for REQUIRED_SQL_MODES. #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
rfk
commented
Apr 4, 2018
| } | ||
|
|
||
| options.master.sql_mode = options.sql_mode | ||
| options.slave.sql_mode = options.sql_mode |
Contributor
Author
There was a problem hiding this comment.
The MySQL module docs don't mention this sql_mode option, so I wasn't sure if it was doing anything, so I deleted it.
This also tweaks the implementation to preserve any existing mode flags on the connection, rather than overwriting them with just the modes from the required list.
rfk
force-pushed
the
configurable-required-sql-modes
branch
from
19aed23 to
fa6d130
Compare
rfk
commented
Apr 4, 2018
| .then( | ||
| assert.fail, | ||
| err => { | ||
| assert.equal(err.message, 'ER_WRONG_VALUE_FOR_VAR') |
Contributor
Author
There was a problem hiding this comment.
The fact that MySQL rejects this value, is a useful test that we are actually attempting to call SET SESSION sql_mode = blah with the provided value.
vladikoff
reviewed
Apr 4, 2018
| }, | ||
| requiredSQLModes: { | ||
| doc: 'Comma-separated list of SQL mode flags to enforce on each connection', | ||
| default: '', |
Contributor
There was a problem hiding this comment.
Looks good, let's just not forget to actually set this at some point :)
Contributor
Author
There was a problem hiding this comment.
If you leave it unset, it should use the hard-coded defaults from const REQUIRED_SQL_MODES; perhaps the config doc here could have made that clearer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also tweaks the implementation to preserve any existing mode flags on the connection, rather than overwriting them with just the modes from the required list. That's in line with how profile-server and oauth-server approach it.
@vladikoff r?