This repository was archived by the owner on Apr 3, 2019. It is now read-only.
fix(tests): increase timeout on recovery code tests #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jrgm
approved these changes
Apr 19, 2018
Contributor
jrgm
left a comment
jrgm
left a comment
There was a problem hiding this comment.
LGTM
But, not sure why the change from () => { to function () {.
Contributor
Author
Using arrow function, timeout wasn't available in the describe block. You would have to put |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases timeout for recovery code related tests and fixes #338. Doing recovery code comparisons (with scrypt) was taking longer than the default 2 second timeout for tests.
@mozilla/fxa-devs r?