This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(account): update stored procedures to be more replication friendly #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vbudhram
force-pushed
the
train-121-fix-replication
branch
from
235a104
to
3c1dd5a
Compare
vbudhram
commented
Oct 18, 2018
| END; | ||
|
|
||
| -- Update session verification methods | ||
| UPDATE `sessionTokens` SET verificationMethod = verificationMethodArg, verifiedAt = verifiedAtArg |
There was a problem hiding this comment.
I significantly tweaked this procedure to only update the verificationMethod on the session table. All previous logic was pulled into the db.verifyTokensWithMethod procedure.
vbudhram
commented
Oct 18, 2018
| WHERE tokenVerificationId = @tokenVerificationId | ||
| AND uid = uidArg; | ||
|
|
||
| DELETE FROM unverifiedTokens |
There was a problem hiding this comment.
I simplified this by removing the transaction portion, which will return the affectedRows from the DELETE. I don't remember the original logic why I put this in a transaction but think it is ok to remove.
There was a problem hiding this comment.
What a pain. It does kinda wanna be a transaction (I logged it, I did it), but...
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our stored procedures to be more replication friendly and is targeted against train-121.