This repository has been archived by the owner. It is now read-only.
feat(geo): add state info into emails #215
Merged
Conversation
|
Looks good, only needs a couple more tests. Thanks! |
| @@ -154,8 +154,12 @@ module.exports = function (log) { | |||
| var location = message.location | |||
| // construct the location string from the location object | |||
| if (location) { | |||
| if (location.city) { | |||
| if (location.city && location.stateCode) { | |||
| return translator.format(translator.gettext('%(city)s, %(stateCode)s, %(country)s (estimated)'), location) | |||
vbudhram
Sep 29, 2016
•
Contributor
Ack looks like you found a gap in our coverage. Mind adding test cases in for
- city and country
- state and country
- only country
Ack looks like you found a gap in our coverage. Mind adding test cases in for
- city and country
- state and country
- only country
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #201
@vbudhram r?