From 577db706a9d25fb825a4eea885d9bcc9f0bedf3b Mon Sep 17 00:00:00 2001 From: Shane Tomlinson Date: Fri, 2 Jun 2017 17:55:40 +0100 Subject: [PATCH] fix(sms): Use the real email sender when sending via MockNexmo We were using a made up sender, which caused our email provider to drop the messages on the ground when testing on fxa-ci. Messages were reported as delivered, but never seen again. --- lib/mock-nexmo.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/mock-nexmo.js b/lib/mock-nexmo.js index 6f6a9e70c..d5de0be23 100644 --- a/lib/mock-nexmo.js +++ b/lib/mock-nexmo.js @@ -39,7 +39,8 @@ function MockNexmo(log, config) { // HACK: Enable remote tests to see what was sent mailer.sendMail({ - from: `sms.${senderId}@restmail.net`, + from: config.smtp.sender, + sender: config.smtp.sender, to: `sms.${phoneNumber}@restmail.net`, subject: 'MockNexmo.message.sendSms', text: message