Permalink
Switch branches/tags
add-security-history-api backend-service-pool bulk-mailer-fix combine-pkg dockerpush-fix-docker-run-npm-ls-production dockerpush-fix-docker-use-base-builder-run-npm-ls-production feature-flag-device-commands feature.hapi17 feature.oauth-as-backend-micro-service feature.oauth-buddy feature.oauth-deps-v4 feature.oauth-dir feature.oauth-gen-keys-2 feature.oauth-gen-keys feature.oauth-import feature.oauth-instance-metadata feature.oauth2tok firefox-special-event fix-moar-enable-newrelic fix-them-ip-address-3 fix-them-ip-addresses geodb-ci handle-null-allowed-scopes hapi i1611 i2717 i2761 issue-6498 master moar-events new-test-workflow oauth-audit-fixes oauth-db-perf-delete-public-tokens oldsync-scope-firefox-desktop openid pb/debug-intermittent-failing-push-e2e-test recaptcha remove-extraneous-profileChangedAt-arg remove-session-on-totp-enabled signed-releases single-pkg-j skip-confirmation-for-emails tap-5.8 test-node-10 tests-add-check-for-sentry-config-setup train-01 train-02 train-03 train-04 train-05 train-06 train-07 train-08 train-10 train-11 train-12 train-13 train-14 train-15 train-16 train-17 train-18 train-19 train-20 train-21 train-22 train-23 train-24 train-27 train-28 train-29 train-30 train-31 train-32 train-33 train-34 train-35 train-36 train-37 train-38 train-39 train-40 train-41 train-42 train-44 train-45 train-46 train-47 train-48 train-56-pre train-65 train-66 train-67 train-68 train-70 train-71 train-75 train-78 train-80 train-81 train-82 train-83 train-89 train-90 train-91 train-92 train-93 train-95 train-96 train-97 train-98 train-99 train-100 train-101 train-104 train-106 train-107 train-108 train-110 train-111 train-112 train-113-deps train-113-force-install-auth-db-mysql train-113 train-114 train-116 train-117 train-118 train-119-3 train-119-callback-simplify train-119-dependency-pinning train-119-push-validation-fix train-119-url-ports train-119 train-120 train-121 train-122 train-123 train-124-uplift train-124 train-125 train-126 train-127 update-password-change use-sinon-assert-helpers v1.53.0-branch v1.63.0-branch
Nothing to show
Commits on Nov 29, 2018
  1. Merge train-126 into master

    philbooth committed Nov 29, 2018
    #2764
    r=vbudhram
  2. Release v1.126.2

    philbooth committed Nov 29, 2018
  3. Merge pull request #2763 from mozilla/pb/activity-109

    philbooth committed Nov 29, 2018
    #2763
    r=vbudhram
Commits on Nov 28, 2018
  1. Merge train-126 into master

    philbooth committed Nov 28, 2018
    #2762
    r=vladikoff
  2. Release v1.126.1

    philbooth committed Nov 28, 2018
  3. Merge pull request #2760 from mozilla/pb/activity-110

    philbooth committed Nov 28, 2018
    #2760
    r=shane-tomlinson
Commits on Nov 9, 2018
Commits on Nov 8, 2018
  1. Merge pull request #2729 from mozilla/pb/wile-e-coyote-vs-geodb

    philbooth committed Nov 8, 2018
    #2729
    r=rfk
  2. chore(tests): make geolocation assertions more robust

    philbooth committed Nov 8, 2018
Commits on Nov 2, 2018
  1. Merge train-124 into master

    philbooth committed Nov 2, 2018
    #2710
    r=shane-tomlinson
  2. Release v1.124.2

    philbooth committed Nov 2, 2018
  3. Merge pull request #2711 from mozilla/pb/email-error-fix

    philbooth committed Nov 2, 2018
    #2711
    r=shane-tomlinson
  4. chore(package): update deps

    philbooth committed Nov 2, 2018
  5. fix(errors): reinstate bounce error failures/messaging

    philbooth committed Nov 2, 2018
    In 75815f2, we added an error for email-sending failure to some routes,
    originally a 500. Then in 17e787b, we switched it to be a 422 because
    the 500 was noisily alerting us in Sentry for lots of cases where a user
    had just misspelled their email address. Then jrgm pointed out that we
    already have error types in place for bounce/complaint checking and we
    should really be propagating those rather than inventing a new error
    type where possible.
    
    So this commit wraps up the `cannotSendEmail` logic into a little helper
    function that:
    
    1. Checks the origin error and propagates that if it is a bounce or
       complaint.
    
    2. Otherwise, returns a 422 if the email address was not previously
       verified.
    
    3. Otherwise, returns a 500.
Commits on Nov 1, 2018
  1. Release v1.124.1

    philbooth committed Nov 1, 2018
  2. Merge train-123 into train-124

    philbooth committed Nov 1, 2018
    #2709
    r=shane-tomlinson
  3. Merge branch 'train-124' into train-123

    philbooth committed Nov 1, 2018
  4. Release v1.123.3

    philbooth committed Nov 1, 2018
  5. Merge pull request #2707 from mozilla/pb/email-error-422

    philbooth committed Nov 1, 2018
    #2707
    r=shane-tomlinson
  6. fix(tests): fix the geodb location assertions again

    philbooth committed Nov 1, 2018
  7. chore(errors): make email-sending errors a 422 for new addresses

    philbooth committed Oct 31, 2018
    In 75815f2, we added an error for email-sending failure to some routes.
    Quite reasonably, we made it a 500 on the assumption that it probably
    indicated a problem somewhere in our email-sending infrastructure, but
    it turns out that in most cases it indicates a user mistyped their email
    address. That causes Sentry to alert us pretty noisily, so this change
    seeks to return a 422 instead in cases where the email address is
    unverified.
    
    Some rationale behind that decision:
    
    * We still want actual infrastructure errors to be a 500, so I opted to
      keep the 500 in place on `/account/login` for verified accounts.
    
    * For unverified accounts in `/account/login`, `/account/create` and
      `POST /recovery_email`, I wanted something different to a 400 so that
      it was distinct from our regular validation errors. The description
      for 422 seemed like a good appropriation for that.
    
    * I avoided adding a new errno because that would require a knock-on
      change in the content server, and we want to target this as a point
      release for train 123.
Commits on Oct 31, 2018
  1. fix(tests): remove assertions of profileChangedAt property

    philbooth committed Oct 30, 2018
    In mozilla/fxa-auth-db-mysql#421, the
    accountRecord_4 stored procedure got rolled back. That means code
    depending on the `profileChangedAt` property will no longer work.
    
    This commit removes the assertions of that property that were added to
    the remote db tests in cca665d, but it
    doesn't revert anything else from that commit. The property is also
    returned from `GET /account/profile` and `POST /certificate/sign`
    endpoints, so the ultimate consumers of those may also need to be on
    their toes.
Commits on Oct 30, 2018
  1. Merge train-124 into master

    philbooth committed Oct 30, 2018
    #2702
    r=shane-tomlinson
  2. Release v1.124.0

    philbooth committed Oct 30, 2018
  3. Release v1.124.0

    philbooth committed Oct 30, 2018
  4. Merge pull request #2701 from mozilla/pb/fix-db-tests

    philbooth committed Oct 30, 2018
    #2701
    r=shane-tomlinson
  5. fix(tests): remove assertions of profileChangedAt property

    philbooth committed Oct 30, 2018
    In mozilla/fxa-auth-db-mysql#421, the
    accountRecord_4 stored procedure got rolled back. That means code
    depending on the `profileChangedAt` property will no longer work.
    
    This commit removes the assertions of that property that were added to
    the remote db tests in cca665d, but it
    doesn't revert anything else from that commit. The property is also
    returned from `GET /account/profile` and `POST /certificate/sign`
    endpoints, so the ultimate consumers of those may also need to be on
    their toes.
  6. Merge pull request #2699 from mozilla/monorepo-oauth-uplift-train-123

    philbooth committed Oct 30, 2018
    #2699
    r=philbooth
Commits on Oct 29, 2018
  1. Merge pull request #2698 from mozilla/pb/fix-notification-format

    philbooth committed Oct 29, 2018
    #2698
    r=shane-tomlinson
  2. fix(metrics): use correct format for email service notifications

    philbooth committed Oct 29, 2018
    The email service made a conscious break with the SQS notification
    structure, to make the recipients array more uniform. Rather than
    sometimes being an object with an `emailAddress` property and other
    times being a string, it makes the items plain strings on all
    notification types.
    
    When I added code for the new notification queue to this repo, I forgot
    about that and just ported the SQS logic verbatim. This fixes it to
    always expect plain strings in the recipient arrays.
Commits on Oct 26, 2018
  1. Merge pull request #2694 from mozilla/pb/log-account-deletes

    philbooth committed Oct 26, 2018
    #2694
    r=shane-tomlinson