Skip to content
This repository has been archived by the owner. It is now read-only.

Add push support for remote disconnect of devices #1139

Closed
vladikoff opened this issue Dec 17, 2015 · 7 comments
Closed

Add push support for remote disconnect of devices #1139

vladikoff opened this issue Dec 17, 2015 · 7 comments
Assignees

Comments

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Dec 17, 2015

When the user clicks "Disconnect" in the device view from the content server sends a device api request to the auth server

TODO:

  • Desktop Patch
  • Payload support : #1132
  • XPCOM Component

This feature requires a Firefox desktop component to listen for push notifications and disconnect itself

image

https://www.lucidchart.com/documents/edit/93d1059c-f2d5-4669-94fa-536a08d5f30c

@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Dec 17, 2015

@kitcambridge is there a link to the bugzilla patch for the new XPCOM Push notifications so we can follow it? Thanks!

@rfk rfk added this to the FxA-54: push on status change milestone Dec 17, 2015
@rfk
Copy link
Member

@rfk rfk commented Dec 17, 2015

The proposal here seems to require message payloads in the push notification. The push folks are welcome to disagree, but I get the strong sense that the payload-handling stuff in webpush is still too in-flux for us to commit to building something on top of it...

@ghost
Copy link

@ghost ghost commented Dec 17, 2015

@vladikoff https://bugzilla.mozilla.org/show_bug.cgi?id=1189998 landed in today's Nightly. The title refers to e10s, but the bug morphed into "clean up all the XPCOM stuff."

I started writing up some docs, but didn't get very far. 😞 For now, the only instructions are the comments in nsIPushService, nsIPushObserverNotification, and PushComponents.js. Happy to help however I can.

@rfk rfk removed this from the FxA-54: push on status change milestone Apr 12, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 20, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 20, 2016
@eoger eoger self-assigned this May 20, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 20, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 20, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 20, 2016
@eoger
Copy link
Contributor

@eoger eoger commented May 20, 2016

Do we have a Bugzilla bug open for the desktop work?

@eoger
Copy link
Contributor

@eoger eoger commented May 23, 2016

@ryanfeeley Do we want to display a notification/warning on Firefox Desktop when the device has been remotely disconnected or do we just sign-out silently?

@ryanfeeley
Copy link
Contributor

@ryanfeeley ryanfeeley commented May 24, 2016

@eoger This is a good idea. Should I file a bug on Bugzilla?

eoger added a commit to eoger/fxa-auth-server that referenced this issue May 24, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 24, 2016
@eoger
Copy link
Contributor

@eoger eoger commented May 24, 2016

Yes please

eoger added a commit to eoger/fxa-auth-server that referenced this issue May 24, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 30, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 30, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 30, 2016
eoger added a commit to eoger/fxa-auth-server that referenced this issue May 30, 2016
@eoger eoger closed this in #1269 May 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants