This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(devices): Remove the unused "device capabilities" API. #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Also, please don't merge this until after we get 113 deployed, to simplify any required point-releases of 113. |
rfk
force-pushed
the
remove-device-capabilities
branch
from
5622c74
to
cf509f2
Compare
This was never used by production clients and is being replaced with "device commands" in a future release.
rfk
force-pushed
the
remove-device-capabilities
branch
from
cf509f2
to
8e9585e
Compare
rfk
commented
May 31, 2018
| @@ -85,7 +85,7 @@ | |||
| "acorn": "5.0.3", | |||
| "commander": "2.9.0", | |||
| "eslint-plugin-fxa": "git+https://github.com/mozilla/eslint-plugin-fxa#master", | |||
| "fxa-auth-db-mysql": "git+https://github.com/mozilla/fxa-auth-db-mysql.git#train-113", | |||
| "fxa-auth-db-mysql": "git+https://github.com/mozilla/fxa-auth-db-mysql.git#master", | |||
There was a problem hiding this comment.
These fixes are required before we can unpin fxa-auth-server from the train-113 branch of db-mysql.
eoger
approved these changes
May 31, 2018
There was a problem hiding this comment.
LGTM, note that if a user has activated "identity.fxaccounts.messages.enabled" they'll send a length 1 capabilities array. I'm tracking this in https://bugzilla.mozilla.org/show_bug.cgi?id=1465638
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never used by production clients and is being replaced with "device commands" in a future release. Let's remove it, but leave stubs in place to accept the "capabilities" array from devices that may still be sending it in the wild.