Skip to content
This repository has been archived by the owner. It is now read-only.

Merge auth-server and oauth-server 🛠 #2668

Closed
vladikoff opened this issue Oct 17, 2018 · 5 comments
Closed

Merge auth-server and oauth-server 🛠 #2668

vladikoff opened this issue Oct 17, 2018 · 5 comments
Assignees

Comments

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Oct 17, 2018

It was a long time proposal from @rfk to uplift the oauth-server into this repo. With the recent exploration into improving devices API I think we finally got to the point where it is worth doing this to make it easier to develop new OAuth features. Let me know if you are against this idea in the comments below. Otherwise Like and Subscribe.

I began work on syncing up dependencies in:

mozilla/fxa-oauth-server#615
mozilla/fxa-oauth-server#616

@vladikoff vladikoff self-assigned this Oct 17, 2018
@philbooth
Copy link
Contributor

@philbooth philbooth commented Oct 17, 2018

Woop! Can we merge fxa-auth-db-mysql in too?!

vladikoff added a commit that referenced this issue Oct 17, 2018
Fixes #2668
@ghost ghost added waffle:active and removed waffle:next labels Oct 17, 2018
@vladikoff vladikoff removed their assignment Oct 19, 2018
@rfk
Copy link
Member

@rfk rfk commented Oct 29, 2018

@rfk to merge with other bug about this

@rfk
Copy link
Member

@rfk rfk commented Oct 30, 2018

I accidentally created a dupe of this over in #2679, but this one has emoji so I'm going to close out #2679 and migrate its checklist over to here.

@rfk
Copy link
Member

@rfk rfk commented Oct 30, 2018

Actually no, this issue is different and broader than #2679; this issue is talking about actually merging the two servers together, while #2679 is a pre-req about making them a monorepo. Let's push forward on the work in #2679 first and we can pick up this one again when @vladikoff returns.

@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Dec 10, 2018

Remaining work is in #2748

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants