Skip to content
This repository has been archived by the owner. It is now read-only.

feat(versions): pull version number from fxa-auth-db-mysql server #1080

Closed
wants to merge 1 commit into from
Closed

feat(versions): pull version number from fxa-auth-db-mysql server #1080

wants to merge 1 commit into from

Conversation

@jamonation
Copy link

@jamonation jamonation commented Oct 15, 2015

Reopening this after #908 went stale a while back, please check that PR for context.

When run against my local fxa-auth-server in docker I get the following:

curl http://127.0.0.1:9000
{
  "version": "1.47.0",
  "commit": "c29a7c3e4bd6ff5e925c9820b7033d1c99ef5424",
  "dbVersion": "0.45.0",
  "source": "git@github.com:jamonation/fxa-auth-server.git"
}
@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Nov 2, 2015

@jrgm to check this...

return new P(function (resolve, reject) {
if (!dbVersion) {
var config = require('../../config').root()
httprequest.get({url: config.httpdb.url, json: true, timeout: 10000}, function (err, response, body) {

This comment has been minimized.

@vladikoff

vladikoff Nov 9, 2015
Contributor

@jrgm there is a 10 sec timeout here, so we can give it a try? (maybe with a shorter timeout) to see how well it works in stage and prod

@jamonation
Copy link
Author

@jamonation jamonation commented Nov 12, 2015

Just a note regarding timeouts from the previous issue:

"I've set timeout to 10000ms in request.get. However, the request docs indicate that in the event of a TCP connection failing, the underlying OS timeout will take precedence. There doesn't appear to be a way to override. Thus, the caveat that the only time the 10s will be useful is if the remote db server is slow to respond, but is listening."

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Dec 11, 2015

Thanks again for this PR! We are gonna close this for now and get back to it later, currently there are a few concerns about fetching the remove DB version from the auth server. We will try to revisit this in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants