Skip to content
This repository has been archived by the owner. It is now read-only.

WIP feat(email): verification reminder email enqueue #1090

Closed
wants to merge 1 commit into from

Conversation

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Oct 28, 2015

Fixes #1081

queueUrl: {
doc: 'The verification reminder queue URL to use (should include https://sqs.<region>.amazonaws.com/<account-id>/<queue-name>)',
format: String,
env: 'VERIFICATION_REMINDER_QUEUE_URL',

This comment has been minimized.

@vladikoff

vladikoff Oct 28, 2015
Author Contributor

@dannycoates are queue permissions guarded by QueuePolicy (ref https://github.com/mozilla/fxa-dev/blob/6c922db044531934ed33f09be78222daee9993c5/aws/cloudformation/moz-single.json#L264 ) or something else? How would you test / access the queue locally?

This comment has been minimized.

@dannycoates

dannycoates Oct 28, 2015
Member

How would you test / access the queue locally?

What do you mean by locally, non-AWS like local-dev?

This comment has been minimized.

@vladikoff

vladikoff Oct 28, 2015
Author Contributor

First to confirm, I assume it is a Yes to

are queue permissions guarded by QueuePolicy?

Otherwise:

What do you mean by locally, non-AWS like local-dev?

For local dev we were planning to have a local (non-AWS) queue to manage these (for self-hosters and non-AWS deployments as well).

However I wanted to test real SQS locally, would the aws-sdk module look for my AWS creds via process.env?

This comment has been minimized.

@dannycoates

dannycoates Oct 28, 2015
Member

However I wanted to test real SQS locally, would the aws-sdk module look for my AWS creds via process.env?

I'm not sure thats such a great idea or necessary, unless you're only doing it for now while you're getting started. It complicates the permissions to SQS. I think we should keep it internal network only.

credentials: via credentials file http://aws.amazon.com/sdk-for-node-js/
policy: http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/UsingIAM.html

This comment has been minimized.

@vladikoff

vladikoff Oct 28, 2015
Author Contributor

unless you're only doing it for now while you're getting started.

Yeap that was the plan, thanks Danny!

@vladikoff vladikoff force-pushed the sqs-verify-email branch 2 times, most recently from cc105e5 to 8730569 Nov 11, 2015
@vladikoff vladikoff force-pushed the sqs-verify-email branch from 8730569 to b086596 Dec 16, 2015
@vladikoff vladikoff force-pushed the sqs-verify-email branch from b086596 to 6cf68ad Dec 26, 2015
@vladikoff vladikoff force-pushed the sqs-verify-email branch from 6cf68ad to d0b39aa Jan 27, 2016
@vladikoff vladikoff force-pushed the sqs-verify-email branch from d0b39aa to 13915e7 Feb 8, 2016
@vladikoff
Copy link
Contributor Author

@vladikoff vladikoff commented Feb 17, 2016

closing this, new PR will use DB instead of SQS

@vladikoff vladikoff closed this Feb 17, 2016
@philbooth philbooth deleted the sqs-verify-email branch Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants