WIP feat(email): Add an explicit error code for when email delivery fails. #1329
Conversation
|
Will errno 127 be surfaced to the content server? We have 1018 right now but that is synthesized and kinda gross. Would be nice to have the auth server just tell us. |
|
Right, the idea would be that this show up to the user as an explicit "we failed to send email" error message. |
|
This is quite stale. The idea seems like a good one, but it'd be nice to decide one way or the other, since it's been open for almost half a year. |
|
Indeed, and I still think this is worth pursuing. Any objections to the approach proposed here, with new error code and detection of errors from the mail delivery agent? |
| }) | ||
| .catch(function (err) { | ||
| // If the email was rejected, delete the account. | ||
| if (err.errno !== error.ERRNO.EMAIL_REJECTED) { |
seanmonstar
Nov 15, 2016
Member
Oh I see, this could be a scary thing to do, considering absolutely any error in the mailer means this errno.
Oh I see, this could be a scary thing to do, considering absolutely any error in the mailer means this errno.
rfk
Nov 15, 2016
Author
Member
Heh, yeah, the missing piece here is figuring out how to get enough error info out of the mailer, that we know for sure this was a delivery failure rather than some other transient error.
Heh, yeah, the missing piece here is figuring out how to get enough error info out of the mailer, that we know for sure this was a delivery failure rather than some other transient error.
|
cc @jrgm |
|
from mtg: todo after fxa-56 doc is merged |
|
I'm going to close this in favour of #1686, now that the auth-mailer has been merged into this repo. |
@jrgm in the morning meeting today, you mentioned a long-standing issue with the auth-server where we eat email delivery failures rather than returning an error. I couldn't find the original issue, but is this along the lines of the fix you'd hoped to see?