This repository has been archived by the owner. It is now read-only.
refactor(signin): Use new verify account sync template and add location data to others #1600
Conversation
|
@vladikoff Auth server portion of https://github.com/mozilla/fxa-auth-mailer/issues/189, r? |
| () => { | ||
| var email = server.uniqueEmail() | ||
| var password = 'allyourbasearebelongtous' | ||
| var client = null | ||
| return Client.create(config.publicUrl, email, password) | ||
| return Client.create(config.publicUrl, email, password, {service: 'sync'}) |
vbudhram
Dec 26, 2016
Author
Contributor
Looks like we had tests but didn't verify correct template, added checks!
Looks like we had tests but didn't verify correct template, added checks!
|
LGTM with one nit |
|
@vladikoff Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR uses the new verify account sync template and adds location data to password change completed and password change requested. It requires
Connects with https://github.com/mozilla/fxa-auth-mailer/issues/189