This repository has been archived by the owner. It is now read-only.
feat(api): add a skeleton request handler for POST /sms #1635
Conversation
|
When I looked into this last year, I tried hooking into the Basket API we already have. |
Oh, interesting. I had not considered that (and don't know a whole ton about basket tbh). Evidently you mean this: https://github.com/mozilla/fxa-basket-proxy/blob/master/lib/routes/sms.js I'll dig into it a bit more and see what I think. |
shane-tomlinson
added this to the
FxA-53: Email Confirmation Flow - SMS (Phase 2) milestone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Related to #1628.
@shane-tomlinson, not sure if there's any value in this for you, we can close it if not. But I figured it may make client-side work easier if a bare-bones, empty route for
/smslanded ahead of the the finished implementation.The only change from what we discussed last week is there's no
localein the payload. I realised we use theAccept-Languageheader for this everywhere else, right?Anyway, let me know if you think this is worth merging on its own or not.