Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

feat(emails): Add secondary email remote tests and documentation Part 3 #1769

Closed
wants to merge 1 commit into from

Conversation

vbudhram
Copy link
Contributor

@vbudhram vbudhram commented Mar 24, 2017

This PR adds documentation and remote tests for additional emails per #1729 (comment), connects with #1672.

Please review part 2 before this one.

@mozilla/fxa-devs r?

@vbudhram vbudhram self-assigned this Mar 24, 2017
@vbudhram vbudhram changed the title feat(email): Add secondary email remote tests and documentation Part 3 feat(emails): Add secondary email remote tests and documentation Part 3 Mar 24, 2017
@philbooth
Copy link
Contributor

On the basis that a PR should be standalone and complete, I kind of think these should get merged with the things that they're testing and documenting, i.e. #1768. By making them a separate PR it feels like we're saying that it would be okay to accept one but not the other, which seems wrong here.

@vbudhram
Copy link
Contributor Author

vbudhram commented Mar 29, 2017

Pulled commit into #1768 ...closing

@vbudhram vbudhram closed this Mar 29, 2017
@vbudhram vbudhram deleted the add-remote-tests branch April 28, 2017 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants