This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
feat(totp): allow reliers to request totp on login #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
vbudhram
force-pushed
the
relier-request-2fa
branch
from
6e18646
to
0eb83bc
Compare
|
@mozilla/fxa-devs r? |
philbooth
approved these changes
Sep 12, 2018
lib/routes/session.js
Outdated
| @@ -142,6 +142,11 @@ module.exports = function (log, db, Password, config, signinUtils) { | |||
| if (result) { | |||
| verificationMethod = 'totp-2fa' | |||
| } | |||
|
|
|||
| // Error if requesting TOTP verification with TOTP not setup | |||
| if (! result && verificationMethod === 'totp-2fa') { | |||
There was a problem hiding this comment.
Probably six of one and half a dozen of the other, but I'm looking at this wondering if the flow would be clearer if it was an else if (verificationMethod === 'totp-2fa') instead of a fresh if (! result && ...). (and above too)
vbudhram
force-pushed
the
relier-request-2fa
branch
from
0eb83bc
to
fa98878
Compare
|
@philbooth Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to mozilla/fxa-oauth-server#520
This PR allow's client to request their login be verified via TOTP. If a user does not have TOTP enabled, it throws an error.