Skip to content
This repository has been archived by the owner. It is now read-only.

added /session/status endpoint #637

Merged
merged 1 commit into from Mar 20, 2014
Merged

added /session/status endpoint #637

merged 1 commit into from Mar 20, 2014

Conversation

@dannycoates
Copy link
Member

@dannycoates dannycoates commented Mar 20, 2014

This adds an endpoint to check whether a sessionToken is still valid.

r?

fixes #610

@ckarlof
Copy link
Contributor

@ckarlof ckarlof commented Mar 20, 2014

r+ from a design perspective.

@zaach zaach mentioned this pull request Mar 20, 2014
2 of 2 tasks complete
@dannycoates dannycoates added the r? label Mar 20, 2014

:lock: HAWK-authenticated with the sessionToken.

Returns the status for the sessionToken. While the request returns a success response, the token is valid.

This comment has been minimized.

@rfk

rfk Mar 20, 2014
Member

Tiny nit: I found "while the request returns..." hard to parse as it suggests some sort of long-poll or iteration; suggest rewording along the lines of "The request will return a success response as long as the token is valid"

@rfk
Copy link
Member

@rfk rfk commented Mar 20, 2014

r+

Although I'm not thrilled about adding new things to the /v1 API without revving a version somewhere. I guess we can still get away with it at this point, but I'll feel a little dirty inside.

@chilts
Copy link
Contributor

@chilts chilts commented Mar 20, 2014

Tests pass locally. Code looks fine. r+ with @rfk's comment about the doc.

On the mention of the API version number, we need to come up with some guidelines perhaps on when to bump. Since this is adding new functionality, it's backwards compatible (AWS do a similar thing, don't bump unless it changes something).

I'm not fussed either way, but clarifications might help now and for the future. :)

@rfk
Copy link
Member

@rfk rfk commented Mar 20, 2014

Since this is adding new functionality, it's backwards compatible

This is fine while we're running the single canonical instance of the API, but it gets a lot muddier once people start running their own servers. Let's take it to the mailing list.

dannycoates added a commit that referenced this pull request Mar 20, 2014
added /session/status endpoint
@dannycoates dannycoates merged commit 1a9c987 into mozilla:master Mar 20, 2014
1 check was pending
1 check was pending
@lightsofapollo
default The Travis CI build is in progress
Details
@dannycoates dannycoates deleted the dannycoates:i610 branch Mar 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants