Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update to 'hi'/'hi-IN' for fxa-auth-server - missing locale. #65

Closed
jrgm opened this issue Aug 16, 2015 · 5 comments
Closed

Cannot update to 'hi'/'hi-IN' for fxa-auth-server - missing locale. #65

jrgm opened this issue Aug 16, 2015 · 5 comments
Assignees

Comments

@jrgm
Copy link
Contributor

@jrgm jrgm commented Aug 16, 2015

Please see mozilla/fxa-auth-server#1019 and https://travis-ci.org/mozilla/fxa-auth-server/jobs/75789764.

I was trying to update to get hi translations for email messages, but it fails because OperationalError: ENOENT, lstat '/Users/jrgm/tmp33/fxa-auth-server/node_modules/fxa-auth-mailer/node_modules/fxa-content-server-l10n/locale/hi'

I can "fix" this by manually copying fxa-auth-server/node_modules/fxa-auth-mailer/node_modules/fxa-content-server-l10n/locale/hi-IN to fxa-auth-server/node_modules/fxa-auth-mailer/node_modules/fxa-content-server-l10n/locale/hi-IN, and editing fxa-auth-server/node_modules/fxa-auth-mailer/node_modules/fxa-content-server-l10n/locale/hi/LC_MESSAGES/server.po to set Language: to hi. Um, obviously?

There are 3 wildcard domains, in fxa-content-server-l10n:

  1. sr/sr_Latn where sr_Latn is, I think, a mechanical translation of Cyrillic to Latin alphabet.
  2. sv/sv_SE where they seem to be independent locales.
  3. hi-IN where there is no corresponding hi.

Can we figure out a way to treat these consistently?

@zaach
Copy link
Contributor

@zaach zaach commented Aug 17, 2015

Right, so we currently copy the files between locales in the content-server, but that of course doesn't help other repos relying on these locales. symlinks in the l10n repo might be a better option.

@rfk rfk added this to the FxA-0: quality milestone Aug 30, 2015
@rfk
Copy link
Member

@rfk rfk commented Oct 19, 2015

The commit adding the copying behaviour for hi-IN => hi, for reference:

mozilla/fxa-content-server@c45edce

@rfk
Copy link
Member

@rfk rfk commented Oct 19, 2015

@jrgm what do you think about me adding a build script to this repo, that would take care of these sorts of things:

  • copying hi-IN => hi
  • creating sr_Latn from sr
  • and maybe even making train-related tags for commits that are being sent to production?

Not sure how well this would fit into your workflow, but it seems sensible to centralize those steps in this repo rather than managing it in dependant repos as done in mozilla/fxa-content-server@c45edce

@rfk
Copy link
Member

@rfk rfk commented Oct 30, 2015

Assigning to @jrgm for comment on the above proposal

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Nov 4, 2015

We are going to try solve this with #81 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants