New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server.po): recover email string translations #36
Conversation
Looks good. Just a quick question. The following pairs are almost identical: Reset password - Reset password: Are they intentionally different or can we unify them? |
@ryanfeeley - what do you think about some unification? "Verify account" and "Verify" seem reasonable. @mathjazz - the colon is to separate the text from a verification link that follows. What is the best practice there? |
OK, in this case "string - string:" pairs should be separate strings, as they could be different parts of speech (verb vs. noun). |
LGTM! @jrgm are these the strings that will be used for today's prod push? |
The prod push is using an earlier hash– this will just affect deployments using fxa-dev. |
That means some strings will be left untranslated after the new release or is this already the case in prod? |
OK. To make "that's usually the case" clear - we usually push to production first and give strings to localizers after that? |
@mathjazz Yeah, actually I merge strings for train 32 earlier than necessary. We could wait and merge them after the current train is pushed to production. As it stands, localizers will have extra time for train 32. |
Okay, thanks for explaining this @zaach! |
Slightly off-topic, but about L10N and production releases, I wrote this micro-note on how the rpm is built with a specific version of fxa-content-server-l10n (default is HEAD). https://github.com/mozilla-services/svcops/blob/master/services/firefox-accounts/fxa-content-server/README.md |
@zaach - it looks like this needs to be rebased or done again. A few commits came in after this PR was created and a clean merge is no longer possible. |
13c967b
to
3d39360
Compare
Rebased. |
Let's hit the merge! |
Merging 👍 |
fix(server.po): recover email string translations
Verbatim updated. But -- it seems like some locales aren't in sync with the templates: (Sort by "Total".) |
@mathjazz Thanks, I've opened another PR. Not sure how those didn't make it into the initial train 32 PR. |
@shane-tomlinson @mathjazz I've added the translations back and updated the template.