New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Localization updates; #79

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@cesperanc
Contributor

cesperanc commented Oct 17, 2015

No description provided.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Oct 19, 2015

Member

@mathjazz - we good to merge?

Member

shane-tomlinson commented Oct 19, 2015

@mathjazz - we good to merge?

@mathjazz

This comment has been minimized.

Show comment
Hide comment
@mathjazz

mathjazz Oct 19, 2015

Contributor

Actually pt-PT should be just a symlink of pt, because they are the same thing and Verbatim only commits to pt, right @cesperanc?

Contributor

mathjazz commented Oct 19, 2015

Actually pt-PT should be just a symlink of pt, because they are the same thing and Verbatim only commits to pt, right @cesperanc?

@cesperanc

This comment has been minimized.

Show comment
Hide comment
@cesperanc

cesperanc Oct 19, 2015

Contributor

Yes, they are the same thing, with the exception of the "Language" tag (on the heading of the files) which seems to be different between those two directories. However the content is, exactly, the same.

Contributor

cesperanc commented Oct 19, 2015

Yes, they are the same thing, with the exception of the "Language" tag (on the heading of the files) which seems to be different between those two directories. However the content is, exactly, the same.

@mathjazz

This comment has been minimized.

Show comment
Hide comment
@mathjazz

mathjazz Oct 19, 2015

Contributor

Good point @cesperanc!

@shane-tomlinson Does that line starting with "Language:" affect anything? I mean, what language will be served to users, who have browser language set to pt or pt-PT?

Contributor

mathjazz commented Oct 19, 2015

Good point @cesperanc!

@shane-tomlinson Does that line starting with "Language:" affect anything? I mean, what language will be served to users, who have browser language set to pt or pt-PT?

@rfk

This comment has been minimized.

Show comment
Hide comment
@rfk

rfk Oct 20, 2015

Member

@jrgm has previously requested that we change the "Language:" line to properly match the name of the file, although I don't recall the specific reason why. It seems like good hygiene in any case.

If it's a straight copy, we should build a way to script up the logic in this repo rather than depending on PRs to keep it up to date.

Member

rfk commented Oct 20, 2015

@jrgm has previously requested that we change the "Language:" line to properly match the name of the file, although I don't recall the specific reason why. It seems like good hygiene in any case.

If it's a straight copy, we should build a way to script up the logic in this repo rather than depending on PRs to keep it up to date.

@shane-tomlinson

This comment has been minimized.

Show comment
Hide comment
@shane-tomlinson

shane-tomlinson Oct 20, 2015

Member

@shane-tomlinson Does that line starting with "Language:" affect anything? I mean, what language will be served to users, who have browser language set to pt or pt-PT?

AFAIK, the "Lanuage" line is not used anywhere. If users have their locale set to pt-PT, we'll ship them the normal pt locales. only pt and pt-BR are enabled in production. We can add pt-PT to the next train if @jrgm gives the green light.

@jrgm, thoughts?

Member

shane-tomlinson commented Oct 20, 2015

@shane-tomlinson Does that line starting with "Language:" affect anything? I mean, what language will be served to users, who have browser language set to pt or pt-PT?

AFAIK, the "Lanuage" line is not used anywhere. If users have their locale set to pt-PT, we'll ship them the normal pt locales. only pt and pt-BR are enabled in production. We can add pt-PT to the next train if @jrgm gives the green light.

@jrgm, thoughts?

@mathjazz

This comment has been minimized.

Show comment
Hide comment
@mathjazz

mathjazz Oct 23, 2015

Contributor

A slight correction. Most projects only keep pt-PT, which makes sense given that there's also pt-BR. And then probably use a symlink or some other mechanism to also serve pt-PT content to pt users.

EDIT: that also means we should merge this.

I agree with @rfk - we should only keep pt-PT and avoid PRs for every change.

Contributor

mathjazz commented Oct 23, 2015

A slight correction. Most projects only keep pt-PT, which makes sense given that there's also pt-BR. And then probably use a symlink or some other mechanism to also serve pt-PT content to pt users.

EDIT: that also means we should merge this.

I agree with @rfk - we should only keep pt-PT and avoid PRs for every change.

@cesperanc

This comment has been minimized.

Show comment
Hide comment
@cesperanc

cesperanc Oct 24, 2015

Contributor

Hi.

I am closing this PR because I've migrated the strings (with some minor updates) to pontoon and they should be pushed to this repository in a few minutes. However the question to serve pt-PT content to pt users still remains open.

Thank you

Contributor

cesperanc commented Oct 24, 2015

Hi.

I am closing this PR because I've migrated the strings (with some minor updates) to pontoon and they should be pushed to this repository in a few minutes. However the question to serve pt-PT content to pt users still remains open.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment