Use CSS for cropper rotation

[zaach]

The cropper rotates the image using canvas, which is really slow on mobile. I'm talking "use a Nexus 5 but still wait 15 seconds to rotate" slow. Let's rotate the image with CSS and do the canvas rotation at export like decent human beings.

[shane-tomlinson]

Use 3d transforms and offload that work to the GPU!

[ckarlof]

@zaach says it might need his love, but @johngruen is going to take a look.

[edwindotcom]

@pdehaan @billmaggs asking QA/Prod if this is a blocker for soft launch?

[pdehaan]

I'm not sure of the % distribution between desktop and mobile, but I'd say that ~10-15seconds is probably a blocker.

[billmaggs]

Yes, I would say that's too slow for a reasonable user to stay with the activity so its a blocker.

[johngruen]

@billmaggs @edmoz @pdehaan @zaach: a few things:

1. the ability to change the avatar appears to be preffed off completely in iOS. I suspect it's preffed off on Android as well. Can we confirm this? Preffing off the feature on mobile would make this non-blocking
2. datadog isn't segmenting OSes very well RN, but android pings to the settings page appear to be very very low.

TL;DR IDK what 'soft launch' means exactly in this context, but I don't think this needs to be blocking.

Also, @zaach and I will be working together next week and can figure out a way to do this with CSS if we have time.

[pdehaan]

Screenshot from my iPhone 4S.

---

I can fire up my Nexus 4/7 and confirm there as well.

[johngruen]

@pdehaan well, f me

[johngruen]

@pdehaan @edmoz: it seems i'm wrong about the current state of avatars on mobile, but it might be a lot simpler to simply use ABLE to disable the feature on mobile than to implement the CSS rotator (considering this bug has languished for a year)

[pdehaan]

Here's a screenshot from my Nexus 7. It doesn't look like my Nexus 4 wants to power up today.

[pdehaan]

FirefoxOS 2.1.0

[eoger]

Pictures around ~500x500px works pretty well on my Nexus 4 (1 sec rotation).
However, big pictures (like this 5000x2000px yummy ramen photo) still take a lot of time to rotate, because of #1916.

[pdehaan]

@eoger does this happen for other types of food, or is it a ramen specific bug?

[TDA]

@pdehaan That was highly relevant I assume? :P

[eoger]

@pdehaan I'm not sure, I'll try to investigate with Hot pot next time, see if I can reproduce the bug.

[zaach]

How does this fare given #2776 has landed? Perhaps we can remove the blocker label if performance is within 1-3 seconds.

[edwindotcom]

per irc - pdehaan is OK to remove blocker tag.

[pdehaan]

I tested using latest.dev.lcip.org and a 8MP 2448x3264px image (1.5MB) on my Nexus 4 and the rotation speeds were pretty good (~2.5s).

[ckarlof]

De-prioritizing for now and removing from avatars-41 milestone.

[shane-tomlinson]

@zaach - is the cropper using CSS or JS now? If CSS, can you close this down?

[zaach]

Still JS 😩

[shane-tomlinson]

Performant enough for now. Closing until we hear of more problems.