Skip to content
This repository has been archived by the owner. It is now read-only.

Create strategy and documentation for changes for localStorage data #1833

Closed
ckarlof opened this issue Nov 3, 2014 · 1 comment
Closed

Create strategy and documentation for changes for localStorage data #1833

ckarlof opened this issue Nov 3, 2014 · 1 comment
Labels

Comments

@ckarlof
Copy link
Contributor

@ckarlof ckarlof commented Nov 3, 2014

Going forward, I'd also like us to be a little more disciplined with how we handle data in localStorage. Bugs involving "legacy" localStorage state are very hard to test and reproduce. Here's what I'd like to see:

  • Document our localStorage layout. This could be in an .md document in this repo.
  • Version the localStorage layout with the train number. If a train changes the localStorage data in any way, we note it in the documentation and annotate the change with the train number. We can explicitly version data in localStorage or do it a more feature detection based way.
  • Run upgrade code on each appStart to make sure everything is up to date. It might start to look something like this:
upgradeTo25();
upgrade25To27();
upgrade27To29();
@ckarlof
Copy link
Contributor Author

@ckarlof ckarlof commented Jul 27, 2015

Let's remember to do this once we make changes to the localStorage format.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants