Skip to content
This repository has been archived by the owner. It is now read-only.

Enable marketing email opt-in in more languages #2676

Closed
rfk opened this issue Jul 2, 2015 · 9 comments
Closed

Enable marketing email opt-in in more languages #2676

rfk opened this issue Jul 2, 2015 · 9 comments
Assignees

Comments

@rfk
Copy link
Member

@rfk rfk commented Jul 2, 2015

Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1179873

We can usefully enable this checkbox for the following languages, which have localized newsletter content: DE, ES, PT-BR, RU, ID, FR, HU, PL.

@shane-tomlinson shane-tomlinson added this to the train 43 milestone Jul 22, 2015
@shane-tomlinson shane-tomlinson self-assigned this Jul 22, 2015
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jul 23, 2015

@rfk - Ben Niolet mentions in the referenced bugzilla bug that we'd have to pass the user's language down to Basket. This bug is more than just enabling the opt-in for those locales. :/

@rfk
Copy link
Member Author

@rfk rfk commented Jul 24, 2015

Per #2452 (comment) the path forward seems to be to just pass on the raw Accept-Lanuage value and let basket figure out how to turn it into a lang. I'll follow up in the linked bugzilla bug.

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jul 26, 2015

Possibly no work in the content server, dependent on the response to https://bugzilla.mozilla.org/show_bug.cgi?id=1179873#c3. mozilla/fxa-content-experiments#25 has been opened to enable more locales.

@rfk
Copy link
Member Author

@rfk rfk commented Jul 28, 2015

Looks like they're going to add the ability to send accept-language with the subscription request: https://bugzilla.mozilla.org/show_bug.cgi?id=1188047

We'll need to wait for the final shape of that API before we can move this forward, but I expect it to be a fairly minor change on our side (e.g. passing along literal accept-language header somehow)

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jul 28, 2015

Looks like they're going to add the ability to send accept-language with the subscription request: https://bugzilla.mozilla.org/show_bug.cgi?id=1188047

So, we have to shuttle the accept-language with the subscribe request and the locale sent in the fxa-register call is ignored?

@rfk
Copy link
Member Author

@rfk rfk commented Jul 28, 2015

Not ignored, but may not be processed reliably by the time they need this information during the subscription process.

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jul 28, 2015

Removing from train-43. Once the Basket portions are available, we can assign this to a train.

@shane-tomlinson shane-tomlinson removed their assignment Jul 28, 2015
@shane-tomlinson shane-tomlinson removed this from the train 43 milestone Jul 28, 2015
@rfk
Copy link
Member Author

@rfk rfk commented Jul 30, 2015

Basket component in review here: mozilla/basket#143

@rfk
Copy link
Member Author

@rfk rfk commented Aug 14, 2015

The modified subscription endpoint is now available in basket: https://bugzilla.mozilla.org/show_bug.cgi?id=1193364

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants