Fennec integration tracking issue. #2771
Comments
|
@ncalexan - which environment are you making this request for? There are a couple of ways to implement your request, I want to make sure we do the right thing and don't cause unexpected change of behavior for existing clients. |
|
@ncalexan - BTW, I'm assuming fennec. |
|
Side note, if a new context is needed, we will need a new column in https://docs.google.com/spreadsheets/d/16Uhb8vtGB_-krMbzaq0b3XYvTWePi_xgIElL7dquohA and corresponding functional tests. |
|
IIUC, Nick would like a "notification" (ie, event or channel message) as the content server transitions to the /signup_complete page, which indicates the user is verified. Or to put it another way, something that would mean the polling we do for the verified flag could be considered a fallback because most of the time we would not get a notification directly from the content server of the state change. |
|
sigh - "because most of the time we would get a notification directly from the content server of the state change" |
|
Your video gave me all the context I need, thanks @ncalexan! |
|
@ncalexan - fennec speaks the WebChannel variant of the messaging protocol, correct? |
@ncalexan - When embedded in about:accounts for desktop, the content server does not poll. Having both the browser and the content server poll was our highest source of load. For about:accounts, the content server redirects from the signup page to the "confirm your email address" page, and stops. At this point, the browser polls in the background. If the about:accounts page is still open when the browser discovers the account is verified, the browser hides the content server and displays its own content. For Fennec, you want the confirm screen to poll, and when the user opens the verification email, if the tab with the confirm screen is still open, it should transition to /settings?
For the verification tab, desktop stops at /signup_complete. We did this because an automatic transition from /signup_complete to /settings gave users little opportunity to read the /signup_complete content, including the marketing material (that says "Go Download Firefox for Android!") that pushes your product. We could add a link to the /signup_complete page that allows the user to go to /settings, which might be a good idea for Desktop as well. @ryanfeeley - can you help with the Fennec flows to ensure both a good experience and consistency with our other products? @ncalexan - I added a new column to the giant flow doc. We will need to fill out the column labelled FxAndroid/Sync with each of the possible scenarios so that we can ensure expectations are understood, that the code matches the expectations, and that we have functional tests that test all of the above. |
|
@ncalexan - for Fennec, what do you think about using |
|
On Thu, Jul 30, 2015 at 5:54 AM, Shane Tomlinson notifications@github.com
|
|
On Thu, Jul 30, 2015 at 6:27 AM, Shane Tomlinson notifications@github.com
|
If `context=fx_fennec_v1` is specified, use the new Fennec broker. issue #2771
If `context=fx_fennec_v1` is specified, use the new Fennec broker. issue #2771
Currently a successful signin goes straight to settings without an intermediate screen. We're working through some tweaks to that for the first-run flow atm (see #2945, #3021), and I kinda like the idea of an intermediate "you signed in, good job!" screen for embedded device flows like this. Would such a screen be sensible/useful in the android case as well, as a success state? |
|
On Thu, Sep 3, 2015 at 7:42 PM, Ryan Kelly notifications@github.com wrote:
Worth noting this applies to both sign up/sign in and force_reauth: @stomlinson, @zaach: sorry I didn't know of this when we talked about |
|
ref #2771 |
|
@ncalexan - also, what's the time frame for this? |
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
* signin_complete, force_auth_complete issue #2771
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
…bjects. This allows for more concise behavior declarations in brokers as well as provide an abstract type that can be consumed by views in an abstract sense. A view just calls the behavior with itself and lets the behavior do the rest. No more adding new code to a bunch of views to add new functionality! issue #2771
* signin_complete, force_auth_complete issue #2771
* signin_complete, force_auth_complete issue #2771
* signin_complete, force_auth_complete issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
* Hook up support for the signin_complete and force_auth_complete screens. * Disable support for the signup marketing material. * Add a "Sync preferences" button to the *_complete screens. issue #2771
Based primarily on @vladikoff's work from commit 223f6d4 * Only enabled for fx_fennec_v1 * Extract `onSignUpSuccess` into its own mixin to share. * Shared between views/permissions.js, views/sign_up.js, and views/choose_what_to_sync.js * Add the fancy new checkboxes to the choose what to sync screen. * Use the newest, flashiest image for "Choose what to Sync" issue #3080 issue #2771
|
I'm closing this since the bulk of user facing work is released and separate issues are filed for the last remaining issues. |
|
Woohoo! |
Two requests:
The text was updated successfully, but these errors were encountered: