Skip to content
This repository has been archived by the owner. It is now read-only.

New Settings header UI tweaks #3055

Closed
johngruen opened this issue Sep 11, 2015 · 7 comments
Closed

New Settings header UI tweaks #3055

johngruen opened this issue Sep 11, 2015 · 7 comments
Assignees

Comments

@johngruen
Copy link
Contributor

@johngruen johngruen commented Sep 11, 2015

Let's make the Avatar a bit bigger and make the overall layout mirror other pages a bit more closely.
@ckarlof @ryanfeeley
settings

@ryanfeeley
Copy link
Contributor

@ryanfeeley ryanfeeley commented Sep 11, 2015

Love it!

@billmaggs
Copy link

@billmaggs billmaggs commented Sep 14, 2015

Much, much better. How about display name in there somewhere if people end up using them?

@johngruen
Copy link
Contributor Author

@johngruen johngruen commented Sep 14, 2015

@billmaggs sure, I can play around with that one...also note to self, @ryanfeeley suggested making the header a bit roomier and the bottom border a bit lighter

@billmaggs
Copy link

@billmaggs billmaggs commented Sep 15, 2015

Looks like there may still be lots of white space in the Settings when seen on Mobile as noted in a previous Issue. May need to be updated.

@rfk
Copy link
Member

@rfk rfk commented Sep 21, 2015

@johngruen is this ready for implementation or do you need to make another round of tweaks?

@rfk rfk added this to the FxA-0: quality milestone Sep 21, 2015
@johngruen
Copy link
Contributor Author

@johngruen johngruen commented Sep 21, 2015

@rfk ready to go. I can knock this one out this week.

@johngruen
Copy link
Contributor Author

@johngruen johngruen commented Oct 2, 2015

@shane-tomlinson @vladikoff fistbumps all around

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants