Skip to content
This repository has been archived by the owner. It is now read-only.

new settings panel blocks waiting on basket /lookup-user #3061

Closed
jrgm opened this issue Sep 15, 2015 · 7 comments
Closed

new settings panel blocks waiting on basket /lookup-user #3061

jrgm opened this issue Sep 15, 2015 · 7 comments
Assignees

Comments

@jrgm
Copy link
Contributor

@jrgm jrgm commented Sep 15, 2015

It looks to me that the new settings panel blocks waiting on basket /lookup-user.

@rfk
Copy link
Member

@rfk rfk commented Sep 16, 2015

Indeed it does, and this will make for a bad experience if there's any basket downtime or slowness. It sounds like our simplest option is to try to delay this request until the user activates the "communication preference" panel, rather than doing it at page load time.

@rfk rfk added this to the FxA-0: quality milestone Sep 17, 2015
@jrgm
Copy link
Contributor Author

@jrgm jrgm commented Sep 18, 2015

This really should be done for train-46 at minimum. It's a big problem.

@ckarlof
Copy link
Contributor

@ckarlof ckarlof commented Sep 18, 2015

Indeed. I had the same concern. Related is #3053.

@rfk
Copy link
Member

@rfk rfk commented Sep 18, 2015

He may not have the bandwidth to take it on himself, but I think we'll need @zaach's advice on the best way to approach this.

@jrgm
Copy link
Contributor Author

@jrgm jrgm commented Sep 20, 2015

"basket" has had problems for hours now, and there is apparently no support for this at all.

New user signups now block for 2.5 seconds, which is a lovely user experience. For hours.

@rfk
Copy link
Member

@rfk rfk commented Sep 21, 2015

New user signups now block for 2.5 seconds

Just to clarify, this blocking occurs when they go to load the settings page at the end of the flow?

We could get brutal and remove this panel from the settings page until we can refactor our way out of this. The only functionality it currently offers is the ability to unsubscribe from the marketing emails, and this functionality is also available via "unsubscribe" and "modify your preferences" links from within the emails themselves.

@jrgm
Copy link
Contributor Author

@jrgm jrgm commented Sep 21, 2015

Just to clarify, this blocking occurs when they go to load the settings page at the end of the flow?

Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants