Skip to content
This repository has been archived by the owner. It is now read-only.

Add custom "unknown account" error for AMO #4302

Closed
ryanfeeley opened this issue Oct 19, 2016 · 23 comments
Closed

Add custom "unknown account" error for AMO #4302

ryanfeeley opened this issue Oct 19, 2016 · 23 comments
Assignees

Comments

@ryanfeeley
Copy link
Contributor

@ryanfeeley ryanfeeley commented Oct 19, 2016

AMO migration is now over, but there are some late stragglers who want their AMO data. These users can still get their data if they use control the email address used for their original account. We can change the message from:

CURRENT:
746bc54596e4deff020a27909a9cc03bc2085b19_1_375x499

PROPOSED:
“Unknown Firefox Account. To retrieve your Add-on data for that account, sign up for a Firefox Account using the same email address."

@mstriemer
Copy link
Member

@mstriemer mstriemer commented Oct 19, 2016

There is also an AMO and FxA support article [1] that might be worth linking to. This message looks good though so that might be enough on its own.

[1] https://support.mozilla.org/en-US/kb/access-your-add-ons-firefox-accounts

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Oct 20, 2016

@mstriemer - I didn't realize until reviewing #4308 that we still have the migration=amo code in place on the content server. Any chance AMO could bring its half back? From out point of view, that would require no work on our end. ;)

@mstriemer
Copy link
Member

@mstriemer mstriemer commented Oct 20, 2016

The migration flow is a bit annoying since it adds an extra step and the user could still run into this if they don't understand what's going on.

Maybe instead of updating the error message (I poked around in the code and it looks non-trivial) we could just have a link to our support documentation in the bottom?

screenshot 2016-10-20 12 26 18

I'm not sure how that would work in languages with longer strings but you get the idea.

@ryanfeeley
Copy link
Contributor Author

@ryanfeeley ryanfeeley commented Oct 20, 2016

Here's an idea. What if the error message instead said:

  • Unknown Firefox Account. Do you want to migrate your old Add-ons account?

Which would then link to a hidden migration experience (same a before, but from a non-advertised URL).

Thoughts?

@mstriemer
Copy link
Member

@mstriemer mstriemer commented Oct 20, 2016

I don't think we need to do anything special to migrate the account. They just need to register for a Firefox Account with the same email address. I could see something like:

  • Unknown Firefox Account. Sign up to access your Add-ons account.

But I feel this could be strange for users that don't have an Add-ons account but thought they might have a Firefox Account or just entered the wrong email or something.

This might be generic enough that new users aren't confused and hopefully it prompts the old users to click that Sign up link.

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Oct 21, 2016

This might be generic enough that new users aren't confused and hopefully it prompts the old users to click that Sign up link.

Sync users make up 95+% of our traffic and a message about signing up for AMO would cause confusion, so we definitely want to limit any AMO specific messaging to AMO users.

Unknown Firefox Account. Sign up to access your Add-ons account.

We may serve the stragglers better by putting some messaging in their face before they attempt to sign in:

screen shot 2016-10-21 at 11 55 51

If the user clicks on the link, it takes them to the /signup page where the same message is displayed, but without the link:

screen shot 2016-10-21 at 11 55 56

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Oct 27, 2016

@shane-tomlinson does this still need feedback from @ryanfeeley ?

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Oct 27, 2016

@vladikoff - yup

@mstriemer
Copy link
Member

@mstriemer mstriemer commented Dec 16, 2016

Was anything done for this? I don't see a linked PR.

We had someone asking on IRC about how to recover their account this morning so it seems people are still hitting this.

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Dec 16, 2016

@vladikoff vladikoff reopened this Dec 16, 2016
@ryanfeeley
Copy link
Contributor Author

@ryanfeeley ryanfeeley commented Dec 16, 2016

@mstriemer Do users call it AMO?

@ryanfeeley
Copy link
Contributor Author

@ryanfeeley ryanfeeley commented Dec 16, 2016

On unknown account error:

  • [RED] Unknown Firefox Account. Sign up using your previous Add-ons account email address to access your Add-ons data.

Always on FxA.AMO registration form:

  • [BLUE] Looking for your Add-ons data? Sign up for a Firefox Account with your old Add-ons account email address.

Always on FxA.AMO login form:

  • [BLUE] Looking for your Add-ons data? Sign up for a Firefox Account with your old Add-ons account email address.
@mstriemer
Copy link
Member

@mstriemer mstriemer commented Dec 18, 2016

Some people refer to it as AMO but I think Add-ons is better, that's what the homepage's heading says. Those messages look good to me.

I might lean towards just including a help link though as that is probably something we can leave around forever. We might want to disable a big blue message if it's mostly irrelevant at some point.

We could potentially pass help_url=https://mzl.la/2hUjOGH and that could be displayed in the footer or as "Unknown account. Need help?" when the error occurs.

It is quite nice to set the expectation before log in though, I'm happy with either one.

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Dec 21, 2016

@shane-tomlinson what do you want to use to "detect AMO"? if name has "Add-ons" in it or something?

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Dec 21, 2016

@shane-tomlinson what do you want to use to "detect AMO"? if name has "Add-ons" in it or something?

Mmmm... Seems a bit brittle. I wonder if we can add AMO's client_id as a config value, and when the front end loads, the content server checks the value of client_id against the known AMO client_id and adds a new configuration item into the config meta tag which is then queried by the front-end. That seems like a lot of work since we'd have to make updates to puppet-config, fxa-dev, etc, and that could be prone to error if the amo client_id ever changes.

Another alternative is to use the no longer sent migration=amo query parameter. We could use that to indicate "show this special text".

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Dec 21, 2016

Another alternative is to use the no longer sent migration=amo query parameter. We could use that to indicate "show this special text".

Yea param would be better, maybe even migration=amo_v2 or something. I don't like the client_id approach because those can rotate and are different on every test server / stage

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Dec 21, 2016

@mstriemer @shane-tomlinson we need to agree on a param that AMO should send via the sign in / sign up attempts. See above ^

@mstriemer
Copy link
Member

@mstriemer mstriemer commented Dec 21, 2016

Sending migration=amo again works for me. If it's easier to use something else that's fine too.

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Dec 21, 2016

@mstriemer @shane-tomlinson bringing back migration=amo works for me 👍

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Dec 23, 2016

@ryanfeeley - In the section Always on FxA.AMO login form:, the phrase "Sign up" is used instead of "Sign in", is "Sign up" correct?

shane-tomlinson pushed a commit that referenced this issue Dec 23, 2016
AMO will open FxA with the `migration=amo` query parameter to indicate
FxA should display some AMO specific help text on signin and signup. If
the user signs in with a non-existent account, show an AMO specific
error message.

fixes #4302
@ryanfeeley
Copy link
Contributor Author

@ryanfeeley ryanfeeley commented Dec 23, 2016

@shane-tomlinson Yes that was deliberate. The thinking is that the first time an old AMO user sees it, they will think "Oh, I can just make an account with my old AMO data" and the second time they see it, they will remember that they'd made an account. Seem sound?

shane-tomlinson pushed a commit that referenced this issue Dec 23, 2016
AMO will open FxA with the `migration=amo` query parameter to indicate
FxA should display some AMO specific help text on signin and signup. If
the user signs in with a non-existent account, show an AMO specific
error message.

fixes #4302
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Dec 23, 2016

Seem sound?

Yeah, just wanted to make sure!

vladikoff added a commit that referenced this issue Dec 23, 2016
…vladikoff

AMO will open FxA with the `migration=amo` query parameter to indicate
FxA should display some AMO specific help text on signin and signup. If
the user signs in with a non-existent account, show an AMO specific
error message.

fixes #4302
@mstriemer
Copy link
Member

@mstriemer mstriemer commented Dec 23, 2016

Thanks everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants