Skip to content
This repository has been archived by the owner. It is now read-only.

failing tests on latest.dev.lcip.org #4339

Closed
jrgm opened this issue Oct 27, 2016 · 4 comments
Closed

failing tests on latest.dev.lcip.org #4339

jrgm opened this issue Oct 27, 2016 · 4 comments
Assignees

Comments

@jrgm
Copy link
Contributor

@jrgm jrgm commented Oct 27, 2016

Last 4 runs, these 3 all fail:

4/4 fail - Firefox Desktop Sync v2 reset password - reset password with a gmail address, get the open gmail button
4/4 fail - confirm - sign up with a gmail address, get the open gmail button
4/4 fail - oauth sign_in - verified, blocked, incorrect password

The last 2 also consistently fail in stage with train-72.

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Oct 27, 2016

4/4 fail - confirm - sign up with a gmail address, get the open gmail button
4/4 fail - oauth sign_in - verified, blocked, incorrect password

These two failures occurred against fxa-dev boxes when rate limiting kicked in.

@jrgm
Copy link
Contributor Author

@jrgm jrgm commented Oct 27, 2016

the verified, blocked, incorrect password will pass if I introduce a 500ms sleep at https://github.com/mozilla/fxa-content-server/blob/master/tests/functional/oauth_sign_in.js#L200

@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Oct 27, 2016

@shane-tomlinson do we need some view Header check in

        .then(testElementExists('#fxa-signin-unblock-header'))
        .then(fillOutSignInUnblock(email, 0))
        // What view should be here before the path is checked?
        .then(testUrlPathnameEquals('/oauth/signin'))
        .then(fillOutSignIn(this, email, PASSWORD))
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Oct 27, 2016

@vladikoff - that's exactly what we needed to do, #4341 opened, mind reviewing?

shane-tomlinson pushed a commit that referenced this issue Oct 28, 2016
vladikoff added a commit that referenced this issue Oct 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants