"sign up, wait for confirmation screen, click resend" test is being rate-limited #4537
Comments
|
I found this nugget in visibleByQSA:
The '#resend' element fades in, using a CSS animation. |
|
I'm going to re-open this until we see results on tc-test. |
|
Issue is due to rate limiting, #4561 (comment) |
Great catch. Do we need to add mailinator to the list on latest too? |
|
@shane-tomlinson i don't think we have a "list" like that for latest. We have this list: https://github.com/mozilla/fxa-customs-server/blob/9b94bd1bdd012217e322d2e008e16f3d7e57c22c/lib/config/config.js#L176 that is used everywhere and I'm not sold about adding mailinator to that list. |
|
Hmm, from that list, who is using mockmyid.com? Persona is no more, mockmyid.com shouldn't work anymore. |
|
@shane-tomlinson I remember seeing Nick Alexander using it for testing some Fennec Sync. @rfk or @jrgm might know of other uses. |
I wouldn't want to add mailinator globally, but I want to get latest functional tests passing. The two obvious workarounds are to add mailinator to the list for latest, or use a different email that won't be rate limited but still provides the functionality we need. |
|
@shane-tomlinson maybe we can just use |
Seems like a winner. |
Yes, I vaguely recall this being one reason. I've also used it in some sync loadtests in the past because it's easy to generate valid assertions for. But given the demise of persona (and the fact that it isn't a Mozilla-owned domain) we should probably work towards replacing it anywhere it's being used. Removing it from the customs bypass list might be a good way to flush out anyone still using it :-) |
|
Ok let's remove it! However then we need another domain we can use in https://github.com/mozilla/fxa-content-server/pull/4583/files |
Replace `mailinator.com` with `restmail.dev.lcip.org`. mailinator addresses are rate limited, restmail.dev.lcip.org is a mozilla controlled server and won't be rate limited. I have not used the `fixes` meta tag below because we have to update the config on latest to not rate limit `restmail.dev.lcip.org` issue #4537
Replace `mailinator.com` with `restmail.dev.lcip.org`. mailinator addresses are rate limited, restmail.dev.lcip.org is a mozilla controlled server and isn't rate limited. fixes #4537
… r=vladikoff Replace `mailinator.com` with `restmail.dev.lcip.org`. mailinator addresses are rate limited, restmail.dev.lcip.org is a mozilla controlled server and isn't rate limited. fixes #4537
This one test failed 3 times in a row:

https://tc-test.dev.lcip.org/viewType.html?buildTypeId=FxaLatest_FunctionalTests
The text was updated successfully, but these errors were encountered: