Skip to content
This repository has been archived by the owner. It is now read-only.

/ fxa-content-server Archived

Fix the "created" green bar in mobile view #4749

Closed
ryanfeeley opened this issue Feb 21, 2017 · 6 comments
Closed

Fix the "created" green bar in mobile view #4749

ryanfeeley opened this issue Feb 21, 2017 · 6 comments
Assignees
@shane-tomlinson
Milestone
FxA-0: quality

Comments

@ryanfeeley
Copy link
Contributor

@ryanfeeley ryanfeeley commented Feb 21, 2017 •
edited by shane-tomlinson

We don't need Choose What To Sync on iOS yet, but may in the future. Currently it looks like the Back link is lacking vertical space, and the green bar is off screen. Not viewed on mobile, but resized my desktop window.
screenshot 2017-02-21 14 40 42
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Feb 22, 2017

We don't need Choose What To Sync on iOS yet

It's used by Android now though.
@shane-tomlinson shane-tomlinson added this to the FxA-0: quality milestone Feb 23, 2017
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Mar 2, 2017

@ryanfeeley - has somebody already fixed this? It looks like this for me:

screen shot 2017-03-02 at 13 34 27

screen shot 2017-03-02 at 13 35 37
@rfk
Copy link
Member

@rfk rfk commented Mar 6, 2017

the green bar is off screen

From meeting, this ^ was the remaining concern.
@ryanfeeley
Copy link
Contributor Author

@ryanfeeley ryanfeeley commented Mar 6, 2017

@shane-tomlinson I think the screenshot you posted above is not our smallest size. Firefox desktop window won't even go small enough to show how it looks on iPhone. Best to use inspector, and slide view small or responsive view.
@vladikoff vladikoff changed the title Make Choose What To Sync screen mobile friendly Fix the "created" green bar in mobile view Mar 6, 2017
@vladikoff
Copy link
Contributor

@vladikoff vladikoff commented Mar 6, 2017

from mtg: renamed
@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Mar 7, 2017

Ah yes, I see it now.
shane-tomlinson pushed a commit that referenced this issue Mar 7, 2017
Shane Tomlinson
fix(CWTS): Fix styles for the trustedUI
Loading status checks…
cc5de51 
* Ensure the success message is displayed.
* Add a little space above the "back" button.

fixes #4749
@shane-tomlinson shane-tomlinson mentioned this issue Mar 7, 2017
Merged
vladikoff added a commit that referenced this issue Mar 7, 2017
Shane Tomlinson @vladikoff
fix(CWTS): Fix styles for the trustedUI (#4786) r=vladikoff
Loading status checks…
e6aa57b 
* Ensure the success message is displayed.
* Add a little space above the "back" button.

fixes #4749
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shane-tomlinson shane-tomlinson

Labels
None yet
Projects
None yet
Milestone
FxA-0: quality
Linked pull requests

Successfully merging a pull request may close this issue.

fix(CWTS): Fix styles for the trustedUI
5 participants
@rfk @philbooth @ryanfeeley @vladikoff @shane-tomlinson