This repository has been archived by the owner. It is now read-only.
User must sign in again after completing password reset #4763
Assignees
Milestone
Comments
|
Oddly, I'm unable to reproduce against local dev servers, only prod. |
Aha! I can locally, with Nightly, after creating a profile using fxa-dev-launcher: FXA_ENV=local FXA_E10S=true npm start |
This was referenced Mar 1, 2017
shane-tomlinson
pushed a commit
that referenced
this issue
Mar 1, 2017
What is the problem? Fx w/ e10s enabled isolates localStorage in about:accounts from localStorage in normal web content. If a user created a new profile and did the reset password flow, completed the reset password flow in the same browser, and then clicked "Manage account", the user would have to sign in again because of this localStorage isolation. The last localStorage write in about:accounts blew away the user's account information, and in fact added a junk account with a uid of `undefined`. How does this fix it? Pass all the data needed to retain the user's session from the confirm_reset_account tab to the about:accounts tab. The passed data will be written to localStorage from the about:accounts tab. Whenever the user clicks Manage Account, the data will be in localStorage, as expected. What is `user.removeAccountsWithInvalidUid`? A bunch of users report having > 1 stored account, it may be most of these are users who have reset their password and have one of these junk accounts. Remove them. fixes #4763 fixes #4769
shane-tomlinson
pushed a commit
that referenced
this issue
Mar 1, 2017
What is the problem? Fx w/ e10s enabled isolates localStorage in about:accounts from localStorage in normal web content. If a user created a new profile and did the reset password flow, completed the reset password flow in the same browser, and then clicked "Manage account", the user would have to sign in again because of this localStorage isolation. The last localStorage write in about:accounts blew away the user's account information, and in fact added a junk account with a uid of `undefined`. How does this fix it? Pass all the data needed to retain the user's session from the confirm_reset_account tab to the about:accounts tab. The passed data will be written to localStorage from the about:accounts tab. Whenever the user clicks Manage Account, the data will be in localStorage, as expected. What is `user.removeAccountsWithInvalidUid`? A bunch of users report having > 1 stored account, it may be most of these are users who have reset their password and have one of these junk accounts. Remove them. fixes #4763 fixes #4769
shane-tomlinson
pushed a commit
that referenced
this issue
Mar 2, 2017
What is the problem? Fx w/ e10s enabled isolates localStorage in about:accounts from localStorage in normal web content. If a user created a new profile and did the reset password flow, completed the reset password flow in the same browser, and then clicked "Manage account", the user would have to sign in again because of this localStorage isolation. The last localStorage write in about:accounts blew away the user's account information, and in fact added a junk account with a uid of `undefined`. How does this fix it? Pass all the data needed to retain the user's session from the confirm_reset_account tab to the about:accounts tab. The passed data will be written to localStorage from the about:accounts tab. Whenever the user clicks Manage Account, the data will be in localStorage, as expected. What is `user.removeAccountsWithInvalidUid`? A bunch of users report having > 1 stored account, it may be most of these are users who have reset their password and have one of these junk accounts. Remove them. fixes #4763 fixes #4769
vladikoff
added a commit
that referenced
this issue
Mar 3, 2017
) r=vladikoff What is the problem? Fx w/ e10s enabled isolates localStorage in about:accounts from localStorage in normal web content. If a user created a new profile and did the reset password flow, completed the reset password flow in the same browser, and then clicked "Manage account", the user would have to sign in again because of this localStorage isolation. The last localStorage write in about:accounts blew away the user's account information, and in fact added a junk account with a uid of `undefined`. How does this fix it? Pass all the data needed to retain the user's session from the confirm_reset_account tab to the about:accounts tab. The passed data will be written to localStorage from the about:accounts tab. Whenever the user clicks Manage Account, the data will be in localStorage, as expected. What is `user.removeAccountsWithInvalidUid`? A bunch of users report having > 1 stored account, it may be most of these are users who have reset their password and have one of these junk accounts. Remove them. fixes #4763 fixes #4769
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have a feeling this links to a whole bunch of bugs, and could be the cause of why so many users have > 1 stored account.
STR
AND! Check out this account data from localStorage:
The userId is
undefined!cc @ryanfeeley
Ref #4060, #4115, #4748, #4769
The text was updated successfully, but these errors were encountered: