Skip to content
This repository has been archived by the owner. It is now read-only.

/ fxa-content-server Archived

SMS form validation only works for the US/CA by default #4861

Closed
shane-tomlinson opened this issue Mar 24, 2017 · 0 comments
Closed

SMS form validation only works for the US/CA by default #4861

shane-tomlinson opened this issue Mar 24, 2017 · 0 comments
Assignees
@shane-tomlinson
Milestone
FxA-53: Mobile Pu...

Comments

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Mar 24, 2017 •
edited by vladikoff

For train-83 the SMS page was enabled for GB and RO. GB was given approval to roll out to the general public, RO is enabled for testing.

There are two problems:

  • GB or RO users won't be able to submit the SMS form. The SMS form does validation on a per-country basis, and we don't yet have the smarts on the frontend to know which country the user is in. @philbooth adds a country field to the /sms/status response in mozilla/fxa-auth-server#1766, we can use this on the front end to set up the form validation correctly.
  • RO should only be enabled for testers, probably via a query parameter. Again, using @philbooth's PR, we can enable RO for users IFF they specify ?country=RO when verifying.

As a short term side-step, @jrgm and @jbuck, can you disable RO & GB in stage/prod for train-83 so we don't give those users a terrible experience?
@shane-tomlinson shane-tomlinson mentioned this issue Mar 24, 2017
Merged
@shane-tomlinson shane-tomlinson self-assigned this Mar 24, 2017
@shane-tomlinson shane-tomlinson mentioned this issue Mar 29, 2017
Merged
shane-tomlinson pushed a commit that referenced this issue Mar 29, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
da201a2 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit to mozilla/fxa-content-experiments that referenced this issue Mar 29, 2017
Shane Tomlinson
feat(sms): Gate SMS by country.
Loading status checks…
39f57d2 
Romania is only enabled for mozilla & softvision addresses.

issue mozilla/fxa-content-server#4861
This was referenced Mar 29, 2017
Merged
Merged
shane-tomlinson pushed a commit that referenced this issue Mar 29, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
023f224 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit that referenced this issue Mar 30, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
3f7a292 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit to mozilla/fxa-content-experiments that referenced this issue Mar 30, 2017
Shane Tomlinson
feat(sms): Gate SMS by country. (#58) r=@vladikoff
Loading status checks…
4e19ee7 
Romania is only enabled for mozilla & softvision addresses.

issue mozilla/fxa-content-server#4861
shane-tomlinson pushed a commit that referenced this issue Mar 30, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
ac25956 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit that referenced this issue Mar 30, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
1c0a2be 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit that referenced this issue Apr 12, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
fb617da 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit that referenced this issue Apr 12, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
90a6626 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit that referenced this issue Apr 12, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
a0d5a29 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit that referenced this issue Apr 13, 2017
Shane Tomlinson
feat(sms): SMS country based updates.
Loading status checks…
5930e2e 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
shane-tomlinson pushed a commit that referenced this issue Apr 13, 2017
Shane Tomlinson
feat(sms): SMS country based updates. (#4872) r=@philbooth, @vbudhram
Loading status checks…
c183737 
* Pass the user's country to the /sms form so that
  the form's validation is set up correctly.
* Add additional gating logic for Romania, if
  the auth server says the user can send an SMS,
  only allow users with softvision.(com|ro)
  addresses to see the SMS form. This allow
  softvision to test w/o exposing the feature
  to everyone else from the country.

fixes #4861
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shane-tomlinson shane-tomlinson

Labels
None yet
Projects
None yet
Milestone
FxA-53: Mobile Push Pt2: SMS install ...
Linked pull requests

Successfully merging a pull request may close this issue.

feat(sms): SMS country based updates.
2 participants
@vladikoff @shane-tomlinson