Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Add some brokers #1609

Merged
merged 5 commits into from Nov 4, 2014
Merged

Add some brokers #1609

merged 5 commits into from Nov 4, 2014

Commits on Oct 31, 2014

  1. feat(test): Add functional test for web channel flow when user signs …

    …up, closes original tab, and opens the verification link in the same browser.
    
    This is to add additional coverage to prepare for the add-a-broker branch.
    
    Additional work:
    * Reduce duplication in the web channel tests by calling the fillOutSignUp and fillOutSignIn FunctionalHelpers.
    Shane Tomlinson committed Oct 31, 2014
    Copy the full SHA
    c2b51b9 View commit details
    Browse the repository at this point in the history
  2. Add FunctionalHelpers to fill out the (request) password reset and co…

    …mplete password reset forms.
    Shane Tomlinson committed Oct 31, 2014
    Copy the full SHA
    2efddfd View commit details
    Browse the repository at this point in the history
  3. feat(client): Add some brokers!

    * Start to add brokers that know how to startup/complete flows.
    * 5 brokers to start, base, oauth, fx-desktop, redirect, web-channel.
    * Get rid of the Channels high level abstraction, these are used directly by the brokers if needed.
    * Move some code from service-mixin and various channels to brokers.
    * Update tests to make use of the brokers.
    * No longer save forceEmail to Session, get it from the relier.
    * Remove the `signIn` from `completeResetPassword` in the FxaClient, this is now done in the views.
    * No longer call `signIn` from `changePassword` in the FxaClient, this is now handled by the views. This allows the signature of `changePassword` to be much smaller.
    * Move the re-link check from fxa-client to the views to allow finer grained control over when they are presented.
    * Remove Session.forceAuth handling from fxa-client.js, this is now stored in relier.email
    * Create a search-params mixin in models/mixins.
    * Migrate signin/signup/verification finishing code from service-mixin to the brokers so each broker can do their own thing.
    * Really shrink service-mixin to a bare bare minimum, fix the unit tests, make sure all the current functional tests pass.
    * Extract a ChannelMixin for use by the brokers.
    Shane Tomlinson committed Oct 31, 2014
    Copy the full SHA
    83ee186 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    2c302d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2014

  1. fix(client): Ensure the Loop initiated reset password verification fl…

    …ow sends OAuth credentials after the reset password is complete when the original tab is closed.
    
    fixes #1825
    Shane Tomlinson committed Nov 3, 2014
    Copy the full SHA
    a91e27b View commit details
    Browse the repository at this point in the history