email confirmation flow. #195
Conversation
| }, | ||
|
|
||
| initialize: function() { | ||
| setTimeout(function() { |
shane-tomlinson
Jan 8, 2014
Author
Member
This is temporary.
This is temporary.
| // TODO - maybe make a light wrapper around Gherkin that takes care | ||
| // of this? | ||
| var client = new gherkin.Client(Constants.FXA_ACCOUNT_SERVER); | ||
| client.verifyEmail(uid); |
shane-tomlinson
Jan 8, 2014
Author
Member
This is sending null for the uid field when making the request to the backend and placing uid into the code field. mmm..
This is sending null for the uid field when making the request to the backend and placing uid into the code field. mmm..
| @@ -99,3 +99,7 @@ a.button:hover, button:hover { | |||
| float: right; | |||
| width: 75%; | |||
| } | |||
|
|
|||
| #fxa-complete-sign-up-success { | |||
nchapman
Jan 9, 2014
Contributor
Let's leave it for now. I'm torn about doing utility classes like that. I'll figure out something consistent in my visual styling branch.
Let's leave it for now. I'm torn about doing utility classes like that. I'll figure out something consistent in my visual styling branch.
| }, | ||
|
|
||
| initialize: function() { | ||
| setTimeout(function() { |
shane-tomlinson
Jan 8, 2014
Author
Member
The setTimeout is necessary to actually get the error message into the element, I need to understand how backbone pieces fit together better.
The setTimeout is necessary to actually get the error message into the element, I need to understand how backbone pieces fit together better.
nchapman
Jan 8, 2014
Contributor
It's because the content hasn't been rendered at that point. I have it setup so that it calls afterRender if that function exists in the view, so you can move that in there and it should work properly.
It's because the content hasn't been rendered at that point. I have it setup so that it calls afterRender if that function exists in the view, so you can move that in there and it should work properly.
shane-tomlinson
Jan 8, 2014
Author
Member
Awesome, I'll update this then.
Awesome, I'll update this then.
|
This depends on #204 and should be merged afterwards. |
* Fetch the code, uid, and service from the URL search string. * Handle errors * In the create_account screen, only attempt to create an account if both email and password are available. * rename tests/functional/signIn.js => sign_in.js and signUp.js => sign_up.js for consistency.
|
On it! |
|
Held up on npm issues. I'll get to it as soon as npm is happy again. |
|
Looks good! |
…eens email confirmation flow.
Details to work out still:
Link to #194