This repository has been archived by the owner. It is now read-only.
fix(client): Only add autocomplete=off when in sync or to text fields acting as passwords.
#1989
Conversation
|
|
||
| describe('setPasswordVisibility', function () { | ||
| it('goes', function () { | ||
| assert.isTrue(true); |
zaach
Dec 16, 2014
Contributor
WIP?
WIP?
shane-tomlinson
Dec 16, 2014
Author
Member
WIP
WIP
shane-tomlinson
force-pushed the
issue-1788-autocomplete-off
branch
5 times, most recently
from
65c4ed9
to
10704d4
| @@ -123,6 +122,7 @@ function (_, Backbone, $, p, AuthErrors, | |||
| }) | |||
| .then(_.bind(self.afterRender, self)) | |||
| .then(function () { | |||
| self.trigger('afterRender'); | |||
shane-tomlinson
Dec 17, 2014
Author
Member
What's this?
What's this?
shane-tomlinson
force-pushed the
issue-1788-autocomplete-off
branch
from
10704d4
to
f79d1fd
| }) | ||
| .end() | ||
|
|
||
| .sleep(5000) |
shane-tomlinson
Dec 17, 2014
Author
Member
need a sleep?
need a sleep?
| @@ -78,7 +78,7 @@ function (chai, jQuery, sinon, BaseView, p, Translator, EphemeralMessages, Metri | |||
|
|
|||
| return view.render() | |||
| .then(function () { | |||
| jQuery('#container').append(view.el); | |||
shane-tomlinson
Dec 17, 2014
Author
Member
jQuery -> $ is an unrelated change for consistency.
append->html ensures the container element is cleared between each test.
jQuery -> $ is an unrelated change for consistency.
append->html ensures the container element is cleared between each test.
…ssword fields! * Always add `autocomplete=off` when the relier is Sync. * Add `autocomplete=off` to text fields acting as passwords, otherwise passwords are displayed in a form autocomplete dropdown. Yuck. fixes #1788
shane-tomlinson
force-pushed the
issue-1788-autocomplete-off
branch
from
f79d1fd
to
7df783f
| @@ -202,21 +202,6 @@ function (chai, sinon, p, AuthErrors, Metrics, FxaClient, InterTabChannel, | |||
| }); | |||
| }); | |||
|
|
|||
| describe('updatePasswordVisibility', function () { | |||
shane-tomlinson
Dec 17, 2014
Author
Member
These tests are moved to the mixins/password-mixin.js set of tests.
These tests are moved to the mixins/password-mixin.js set of tests.
| @@ -105,7 +105,7 @@ function (chai, _, $, moment, sinon, p, View, Session, AuthErrors, Metrics, | |||
|
|
|||
| return view.render() | |||
| .then(function () { | |||
| $('#container').append(view.el); | |||
| $('#container').html(view.el); | |||
shane-tomlinson
Dec 17, 2014
Author
Member
append->html ensures the container is cleared between each test.
append->html ensures the container is cleared between each test.
|
Removing the WIP - ready for review! |
shane-tomlinson
changed the title
autocomplete=off when in sync or to text fields acting as passwords.autocomplete=off when in sync or to text fields acting as passwords.
|
Excellent! |
zaach
added a commit
that referenced
this pull request
Dec 23, 2014
fix(client): Only add `autocomplete=off` when in sync or to text fields acting as passwords.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fixes #1788