This repository has been archived by the owner. It is now read-only.
fix(avatars): Redirect to settings/avatar/change on error #2446
Conversation
| } catch (e) { | ||
| return done(e); | ||
| } | ||
| }); |
zaach
May 20, 2015
Contributor
Now that view.fileSet is a promise you can remove the done callback and simply return view.fileSet here and also return view.afterVisible so the test will catch any errors.
Now that view.fileSet is a promise you can remove the done callback and simply return view.fileSet here and also return view.afterVisible so the test will catch any errors.
eoger
May 20, 2015
Author
Contributor
Good catch, I did the change and rebased everything
Good catch, I did the change and rebased everything
|
Nice! |
zaach
added a commit
that referenced
this pull request
May 20, 2015
fix(avatars): Redirect to settings/avatar/change on error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #2428,
I also took the liberty to redirect errors to settings/avatar/change when an uploaded avatar is invalid or corrupted.