fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser #2447

vladikoff · 2015-05-20T18:08:39Z

shane-tomlinson · 2015-05-20T21:14:10Z

app/scripts/views/form.js

@@ -176,6 +176,7 @@ function (_, $, p, Validate, AuthErrors, BaseView, Tooltip,
          }

          // all good, do the beforeSubmit, submit, and afterSubmit chain.
+          self.logScreenEvent('submit');


@vladikoff - can you add this event to client-metrics.md, probably under generic-events?

nm, took care of it.

vladikoff · 2015-05-20T21:21:15Z

Need to fix the "old tab is closed" case...

vladikoff · 2015-05-20T21:23:33Z

from meeting: if old tab was closed, then the newly opened tab should complete the flow automatically....

shane-tomlinson · 2015-05-21T08:06:12Z

from meeting: if old tab was closed, then the newly opened tab should complete the flow automatically....

@vladikoff - can you define the expected behavior exactly, for posterity, and so I can eventually update the google doc?

coveralls · 2015-05-21T18:34:03Z

Coverage increased (+0.0%) to 98.34% when pulling 8b2b0e9 on vladikoff:issue-2436-verification-redirect-strikes-back into 927e97f on mozilla:master.

vladikoff · 2015-05-21T18:36:44Z

I removed samebrowser until we actually have to use it or until someone needs it.
Updated google doc
@zaach @shane-tomlinson r?

pdehaan · 2015-05-21T19:20:52Z

app/scripts/views/ready.js

+     *
+     * @returns {boolean}
+     *  if the "Proceed" button should be included in the template
+     *  The button links to the "redirect_uri" with no extra OAuth information


Not sure if these comments should be above or below the @returns meta.

coveralls · 2015-05-21T19:53:04Z

Coverage increased (+0.0%) to 98.24% when pulling 0d68853 on vladikoff:issue-2436-verification-redirect-strikes-back into 398f70a on mozilla:master.

zaach · 2015-05-22T21:52:16Z

👍 lgtm

…rowser or show "proceed" in different browser Fixes #2436 Fixes #2402

vladikoff · 2015-05-24T20:12:15Z

Merging this so we get some time to test it on latest before train cut.

…ect-strikes-back fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser

vladikoff added the waffle:needs review label May 20, 2015

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch from f18f588 to bdae8c0 May 20, 2015

vladikoff added the WIP label May 20, 2015

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch from bdae8c0 to 94c1907 May 20, 2015

shane-tomlinson reviewed May 20, 2015
View changes

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch from 94c1907 to 3fe519c May 20, 2015

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch from 3fe519c to 8b2b0e9 May 21, 2015

vladikoff removed the WIP label May 21, 2015

vladikoff added this to the train 38 milestone May 21, 2015

vladikoff changed the title ~~fix(oauth): update verification_redirect to always show "proceed"~~ fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser May 21, 2015

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch from 8b2b0e9 to 75b8c4d May 21, 2015

pdehaan reviewed May 21, 2015
View changes

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch 2 times, most recently from d862883 to 0d68853 May 21, 2015

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch from 0d68853 to 4ab8970 May 22, 2015

fix(oauth): update verification_redirect to always redirect in same b…

3be6da9

…rowser or show "proceed" in different browser Fixes #2436 Fixes #2402

vladikoff force-pushed the vladikoff:issue-2436-verification-redirect-strikes-back branch from 4ab8970 to 3be6da9 May 22, 2015

vladikoff added a commit that referenced this pull request May 24, 2015

Merge pull request #2447 from vladikoff/issue-2436-verification-redir…

822f105

…ect-strikes-back fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser

vladikoff merged commit 822f105 into mozilla:master May 24, 2015
1 of 2 checks passed

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

vladikoff removed the waffle:needs review label May 24, 2015

vladikoff deleted the vladikoff:issue-2436-verification-redirect-strikes-back branch May 24, 2015

mozilla / fxa-content-server Archived

fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser #2447

fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser #2447

vladikoff commented May 20, 2015

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vladikoff commented May 20, 2015

vladikoff commented May 20, 2015

shane-tomlinson commented May 21, 2015

coveralls commented May 21, 2015

vladikoff commented May 21, 2015

This comment has been minimized.

coveralls commented May 21, 2015

zaach commented May 22, 2015

vladikoff commented May 24, 2015

mozilla / fxa-content-server Archived

fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser #2447

fix(oauth): update verification_redirect to always redirect in same browser or show "proceed" in different browser #2447

Conversation

vladikoff commented May 20, 2015

This comment has been minimized.

shane-tomlinson May 20, 2015 Member

This comment has been minimized.

shane-tomlinson May 25, 2015 Member

This comment has been minimized.

shane-tomlinson May 25, 2015 Member

vladikoff commented May 20, 2015

vladikoff commented May 20, 2015

shane-tomlinson commented May 21, 2015

coveralls commented May 21, 2015

vladikoff commented May 21, 2015

This comment has been minimized.

pdehaan May 21, 2015 Contributor

coveralls commented May 21, 2015

zaach commented May 22, 2015

vladikoff commented May 24, 2015

shane-tomlinson May 20, 2015
Member

shane-tomlinson May 25, 2015
Member

shane-tomlinson May 25, 2015
Member

pdehaan May 21, 2015
Contributor