refactor(app): remove unused amd requires

[riadhchtara]

Fixes #2392

[riadhchtara]

@vladikoff : i don't why my previous pull request was closed. Cold you please have look to the pr quickly before some new conflicts appear?
Thanks

[coveralls]

Coverage remained the same at 98.34% when pulling 99fe4d2 on riadhchtara:amd into 83d3fb1 on mozilla:master.

[vladikoff]

We cannot remove this, polyfill for older browsers:

fxa-content-server/app/scripts/views/settings/avatar_camera.js

Line 200 in cfe4db3

this.canvas.toBlob(function (data) {

Needs exceptsPaths

[riadhchtara]

ah ok

[vladikoff]

This needs to be updated: #2448 (comment)

Secondary:

As part of a separate PR (to minimize diff) add the

tests/functional/**/*.js

files to amdcheck as well.

Report for those:

➜  fxa-content-server git:(riadhchtara-amd) grunt amdcheck
Running "amdcheck:app" (amdcheck) task
tests/functional/404.js (1 module)
Unused paths: intern/chai!assert

tests/functional/500.js (1 module)
Unused paths: intern/chai!assert

tests/functional/avatar.js (1 module)
Unused paths: app/scripts/lib/constants

tests/functional/bounced_email.js (1 module)
Unused paths: intern/chai!assert

tests/functional/delete_account.js (1 module)
Unused paths: intern/chai!assert

tests/functional/firefox/functional_firefox.js (1 module)
Unused paths: ./same_account

tests/functional/firefox/same_account.js (1 module)
Unused paths: intern/chai!assert

tests/functional/force_auth.js (1 module)
Unused paths: intern/node_modules/dojo/Deferred, tests/lib/restmail

tests/functional/oauth_force_email.js (1 module)
Unused paths: require

tests/functional/oauth_iframe.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/oauth_preverified_sign_up.js (1 module)
Unused paths: intern/node_modules/dojo/node!xmlhttprequest, app/bower_components/fxa-js-client/fxa-client, tests/lib/restmail

tests/functional/oauth_reset_password.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/oauth_sign_up.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/oauth_sign_up_verification_redirect.js (1 module)
Unused paths: intern, intern/node_modules/dojo/node!xmlhttprequest, tests/lib/restmail

tests/functional/oauth_sync_sign_in.js (1 module)
Unused paths: intern/node_modules/dojo/node!leadfoot/helpers/pollUntil

tests/functional/oauth_webchannel.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/oauth_webchannel_keys.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/pages.js (1 module)
Unused paths: intern/chai!assert

tests/functional/pp.js (1 module)
Unused paths: intern/chai!assert

tests/functional/settings_common.js (1 module)
Unused paths: intern/chai!assert, app/scripts/lib/constants

tests/functional/sign_in.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/sign_in_cached.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/sign_up.js (1 module)
Unused paths: intern/node_modules/dojo/node!leadfoot/helpers/pollUntil

tests/functional/sync_reset_password.js (1 module)
Unused paths: tests/lib/restmail

tests/functional/sync_settings.js (1 module)
Unused paths: intern/chai!assert, app/scripts/lib/constants

tests/functional/sync_sign_in.js (1 module)
Unused paths: intern/chai!assert, intern/node_modules/dojo/node!leadfoot/helpers/pollUntil

tests/functional/sync_sign_up.js (1 module)
Unused paths: intern/node_modules/dojo/node!leadfoot/helpers/pollUntil

tests/functional/tos.js (1 module)
Unused paths: intern/chai!assert


Total unused paths: 36 in 28 files.
Total unused dependencies: 35 in 27 files.
Total processed files: 288
Warning: Task "amdcheck:app" failed. Use --force to continue.

I will create a new issues after this PR gets merged to track the secondary task above.

[riadhchtara]

@vladikoff : thanks for the review.
How about this new patch?
I will work on the new tests/functional later, when this PR is merged as you said.

[coveralls]

Coverage remained the same at 98.24% when pulling fe05dc6 on riadhchtara:amd into 398f70a on mozilla:master.

[vladikoff]

@riadhchtara Please rebase this against master https://github.com/mozilla/fxa-content-server/tree/master

[riadhchtara]

@vladikoff : hi ! I have just done! the rebase, could you p0lease review it quickly!
there are so many files changed here so there is a big probability that a conflict appearers.
Thanks

[coveralls]

Coverage remained the same at 98.25% when pulling 958e386 on riadhchtara:amd into 0860054 on mozilla:master.

[pdehaan]

Great job, thanks again @riadhchtara!

[vladikoff]

Yeah this should be really useful!

[riadhchtara]

YES!!! it landed after 4 or 5 rebases.
@vladikoff @vladikoff thanks for you too guys