Skip to content
This repository has been archived by the owner. It is now read-only.

fix(oauth): strip permissions that are not on the whitelist #2478

Merged
merged 1 commit into from May 26, 2015

Conversation

@zaach
Copy link
Contributor

@zaach zaach commented May 26, 2015

This pares down the scopes we receive from the relier so that we only grant the ones we currently prompt for.

@vladikoff r?

@coveralls
Copy link

@coveralls coveralls commented May 26, 2015

Coverage Status

Changes Unknown when pulling a6a22c0 on strip-non-whitelisted-permissions into * on master*.

vladikoff added a commit that referenced this pull request May 26, 2015
fix(oauth): strip permissions that are not on the whitelist r=vladikoff
@vladikoff vladikoff merged commit 1b740d3 into master May 26, 2015
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 98.39%
Details
@vladikoff vladikoff deleted the strip-non-whitelisted-permissions branch May 26, 2015
@jrgm
Copy link
Contributor

@jrgm jrgm commented May 27, 2015

Yeah @zaach, on {accounts,oauth,profile,api-accounts}.stage.mozaws.net I'm still seeing POST /v1/authorization requesting "scope":"profile:uid profile:email profile:display_name"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants