Skip to content
This repository has been archived by the owner. It is now read-only.

Update COPPA to be done on the sign_up screen. #268

Merged
merged 3 commits into from Jan 17, 2014
Merged

Conversation

@shane-tomlinson
Copy link
Member

@shane-tomlinson shane-tomlinson commented Jan 16, 2014

  • Use a session cookie to keep track of whether the user is too young.
  • If the user revisits the signup page after being booted out for being too young, ship them back to the "cannot_create_account" page.
  • Update the text on the Cannot Create Account screen to go along with @jgruen's new mocks and legal's feedback.

fixes #265
fixes #259

@shane-tomlinson
Copy link
Member Author

@shane-tomlinson shane-tomlinson commented Jan 16, 2014

A note to whomever tests - In Firefox Nightly at least, two things must happen for the session cookie to go away and the user to be able to sign up again:

  1. the tab the attempted to sign in on must be closed.
  2. the browser must be closed.

Any deviation from this, and you are booted directly back to the /cannot_create_account screen.

@shane-tomlinson
Copy link
Member Author

@shane-tomlinson shane-tomlinson commented Jan 16, 2014

Screen shot of the new sign up screen:

screen shot 2014-01-16 at 21 07 34

@ghost ghost assigned nchapman Jan 17, 2014
@nchapman
Copy link
Contributor

@nchapman nchapman commented Jan 17, 2014

On it.

@nchapman
Copy link
Contributor

@nchapman nchapman commented Jan 17, 2014

@shane-tomlinson It looks like account creation and therefore errors are still happening in a different view. Do you see any problem with us moving all of that into the SignUp view?

Shane Tomlinson added 3 commits Jan 16, 2014
* Use a session cookie to keep track of whether the user is too young.
* If the user revisits the signup page after being booted out for being too young, ship them back to the "cannot_create_account" page.
* Update the text on the Cannot Create Account screen to go along with @jgruen's new mocks and legal's feedback.

issue #226
* Delete the old interstitial screen.
* Simplify!
@nchapman
Copy link
Contributor

@nchapman nchapman commented Jan 17, 2014

Email address is missing during sign up:

screen shot 2014-01-17 at 2 59 52 pm

@shane-tomlinson
Copy link
Member Author

@shane-tomlinson shane-tomlinson commented Jan 17, 2014

@nchapman - moved the fxaClient.signUp portions of the code from /create_account to /signin so the error messages stay on the same screen.

@shane-tomlinson
Copy link
Member Author

@shane-tomlinson shane-tomlinson commented Jan 17, 2014

@nchapman:

screen shot 2014-01-17 at 23 02 05

so confused!

@nchapman
Copy link
Contributor

@nchapman nchapman commented Jan 17, 2014

@shane-tomlinson Sorry about that! I didn't have the latest code :(. It seems to be working wonderfully now.

@nchapman
Copy link
Contributor

@nchapman nchapman commented Jan 17, 2014

All seems well. Sign in, Sign up, and age restriction all seem to be working as expected. Great work @shane-tomlinson!

nchapman added a commit that referenced this pull request Jan 17, 2014
Update COPPA to be done on the sign_up screen.
@nchapman nchapman merged commit 269d945 into master Jan 17, 2014
1 check passed
1 check passed
@rik
default The Travis CI build passed
Details
@nchapman nchapman deleted the issue-265-coppa-updates branch Jan 17, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants