This repository has been archived by the owner. It is now read-only.
fix(signup): show red border only after tooltip rendered #3120
Conversation
|
Tests are failing if you open http://localhost:3030/tests/index.html?grep=views%2Fform |
|
Updated the tests to wait for the tooltip to be rendered. EDIT: Commits squashed. |
| @@ -354,7 +354,9 @@ function (chai, sinon, $, p, FormView, Template, Constants, Metrics, AuthErrors, | |||
|
|
|||
| it('adds invalid class to the invalid element', function () { | |||
vladikoff
Oct 1, 2015
Contributor
this needs a done callback , + done() in the timeout, you can find it in other tests
this needs a done callback , + done() in the timeout, you can find it in other tests
| return view.render() | ||
| .then(function () { | ||
| return view.afterVisible(); | ||
| }) | ||
| .then(function () { | ||
| assert.isTrue(view.showValidationError.called); | ||
| self.timeout(function () { | ||
| assert.isTrue(view.$('input[type="email"]').hasClass('invalid')); |
|
@npestana go ahead and squash these commits when you have time |
Add addClass('invalid') to invalid field only after the tooltip rendered.
Update tests to wait for the tooltip to be rendered.
Closes #1865
|
Commits squashed. :) |
vladikoff
added a commit
that referenced
this pull request
Oct 1, 2015
fix(signup): show red border only after tooltip rendered r=vladikoff
|
Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add addClass('invalid') to invalid field only after the tooltip rendered.
Closes #1865