This repository has been archived by the owner. It is now read-only.
fix(client): Suppress spurious login messages to the browser.
#3155
Conversation
shane-tomlinson
changed the title
login messages to the browser.login messages to the browser.
shane-tomlinson
force-pushed the
issue-3078-spurious-login
branch
3 times, most recently
from
e74ba46
to
2c1b478
|
|
||
| .then(function () { | ||
| return testIsBrowserNotifiedOfLogin(self, email); |
shane-tomlinson
Oct 12, 2015
Author
Member
This PR uncovered the fact that this test was incorrect, and because of lucky timing, not failing. The account used to sign in was verified, yet testIsBrowserNotifiedOfLogin should have been failing because by default, it checks if the account is unverified.
This PR uncovered the fact that this test was incorrect, and because of lucky timing, not failing. The account used to sign in was verified, yet testIsBrowserNotifiedOfLogin should have been failing because by default, it checks if the account is unverified.
If the user signs up but does not verify their account, then visit `/` or `/settings`, they are redirected to `/confirm` which attempts to notify the browser of login. Neither `unwrapBKey` and `keyFetchToken` are persisted to disk. If `/confirm` is shown in a tab other than the original tab, `notifyBrowserOfLogin` is called with an account without these fields. The browser can't do anything without this information, so don't actually send the message. fixes #3078
shane-tomlinson
force-pushed the
issue-3078-spurious-login
branch
from
2c1b478
to
23fbe8b
vladikoff
added a commit
that referenced
this pull request
Oct 13, 2015
fix(client): Suppress spurious `login` messages to the browser. r=vladikoff
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
If the user signs up but does not verify their account,
then visit
/or/settings, they are redirected to/confirmwhich attempts to notify the browser of login.
Neither
unwrapBKeyandkeyFetchTokenare persisted to disk.If
/confirmis shown in a tab other than the original tab,notifyBrowserOfLoginis called with an account without thesefields. The browser can't do anything without this information,
so don't actually send the message.
fixes #3078
@vladikoff or @zaach - r?