This repository has been archived by the owner. It is now read-only.
fix(tests): add a way to disable client metrics stderr #3209
Conversation
| @@ -48,6 +48,13 @@ var conf = module.exports = convict({ | |||
| default: path.resolve(__dirname, '..', '..', 'cert.pem'), | |||
| doc: 'The location of the SSL certificate in pem format' | |||
| }, | |||
| client_metrics: { | |||
| enabled: { | |||
shane-tomlinson
Oct 22, 2015
Member
client_metrics.enabled implies a global on/off switch of client metrics, whereas this flag only enables/disables output to stderr. Maybe this should be something like:
client_metrics: {
stderr_collector_enabled: {
...
},
statsd_collector_enabled: {
...
}
}
I could also see something like:
client_metrics: {
collectors: {
default: [ 'ga', 'stderr', 'statsd' ],
doc: 'Where to send client metrics'
}
}
client_metrics.enabled implies a global on/off switch of client metrics, whereas this flag only enables/disables output to stderr. Maybe this should be something like:
client_metrics: {
stderr_collector_enabled: {
...
},
statsd_collector_enabled: {
...
}
}I could also see something like:
client_metrics: {
collectors: {
default: [ 'ga', 'stderr', 'statsd' ],
doc: 'Where to send client metrics'
}
}
I left my comments, back to @vladikoff |
|
@shane-tomlinson I updated this to be more consistent with the "DISABLE_..." options we already have. Also added some tests. If we need to mute statsd and other logging we can add that later if required, following the same pattern. |
|
uh metrics-unit keeps failing on node 0.10, will need to check what is going on, otherwise should be ready. |
|
Updated and should be ready! |
|
https://travis-ci.org/mozilla/fxa-content-server/jobs/90769425 No more client metrics! Now if we could just get rid of all this cruft: |
shane-tomlinson
pushed a commit
that referenced
this pull request
Nov 13, 2015
fix(tests): add a way to disable client metrics stderr r=@shane-tomlinson
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #3158