This repository has been archived by the owner. It is now read-only.
fix(build): Only copy resources to dist if they are used. #4186
Conversation
shane-tomlinson
force-pushed the
issue-4177-only-cachable-resources-in-dist
branch
from
e7e4eea
to
5abe3bd
No need to copy over jquery-ui, fxa-checkbox, and styles/fonts to dist. These JS resources are included into the built bundle and not loaded dynamically. There is no need to copy these over. Remove jquery-ui from the rev task. issue #4177
shane-tomlinson
force-pushed the
issue-4177-only-cachable-resources-in-dist
branch
from
26cacc2
to
0f617b5
shane-tomlinson
changed the title
|
@shane-tomlinson needs rebase |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No need to copy over jquery-ui, fxa-checkbox, and styles/fonts to dist.
These JS resources are included into the built bundle and not loaded dynamically. There is no need to copy these over.
Remove jquery-ui from the rev task.
issue #4177
@vladikoff and @jrgm - can you make sure I'm not losing it and that the built JS really does not need these files loaded separately?