This repository has been archived by the owner. It is now read-only.
fix(metrics): Stop double counting the *_complete screen views.
#4306
Conversation
|
ref #4307 |
`(signin|signup|reset_password)_complete` screens were shown in both the initiating tab and the verification tab of these flows, which meant that the `*_complete` events were often counted twice. This makes properly measuring things almost impossible. New nomenclature: * In the initiating tab, when the action completes, transition from `confirm_*` to `*_confirmed`. * In the verification tab, when the action completes, transition from `verify_email|(complete_reset_password|complete_signin) to `(signin|signup|reset_password)_verified` I would also like to make the following changes in a future PR: * `verify_email` => `verify_signup` * `complete_signin` => `verify_signin` * `complete_reset_password` => `verify_reset_password` These changes would make the nomenclature consistent. fixes #4242
shane-tomlinson
force-pushed the
shane-tomlinson/issue-4242-stop-double-count-complete
branch
from
152f07a
to
1be8ce9
|
LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
(signin|signup|reset_password)_completescreens were shown in both theinitiating tab and the verification tab of these flows, which meant
that the
*_completeevents were often counted twice. This makesproperly measuring things almost impossible.
New nomenclature:
confirm_*to*_confirmed.verify_email|(complete_reset_password|complete_signin) to(signin|signup|reset_password)_verified`I would also like to make the following changes in a future PR:
verify_email=>verify_signupcomplete_signin=>verify_signincomplete_reset_password=>verify_reset_passwordThese changes would make the nomenclature consistent.
fixes #4242