WIP feat(client): complete on fennec #4370

shane-tomlinson · 2016-11-03T20:27:33Z

Builds on #4395

rfk · 2016-11-03T20:47:44Z

❤️

One question I had when I saw this demo was around PII handling. IIUC this will technically share your email address with our SMS provider, if they wanted to go looking for it in the links we're sending out. If so then we should parallelize and seek data-approval at the same time as we're working on the code here.

(I'm having flashbacks to Gravatar where we had to add a permission box to even send them the hash of your email address)

shane-tomlinson · 2016-11-03T21:14:35Z

The title was misnamed, this is only "open verification link in fennec and allow the user to sign in". SMS is a much larger project that will not be part of this PR.

We are developing this portion independently so that it can merge w/o being blocked on SMS work.

vladikoff · 2016-11-04T14:53:32Z

app/scripts/templates/connect_this_firefox.mustache

+
+    <form novalidate>
+      <div class="button-row">
+        <a class="button" href="{{{ escapedSignInUrl }}}">{{#unsafeTranslate}}Continue &rarr;{{/unsafeTranslate}}</a>


please add a class or an id to this button

vladikoff · 2016-11-07T02:52:11Z

tests/functional/lib/helpers.js

-          assert.equal(resultText, expected);
-        })
-        .end();
+        .then(testAttributeEquals(selector, href, expected));


👍 niiice

vladikoff · 2016-11-14T20:05:35Z

#4395 landed so we can now use UAP for this

vladikoff · 2016-11-17T19:01:09Z

@shane-tomlinson is this waiting for the feature doc phase 1?

shane-tomlinson · 2016-11-17T19:56:13Z

@shane-tomlinson is this waiting for the feature doc phase 1?

It's waiting on that, and on time from me. I'm pulling parts out of this to merge independently, will have a PR later.

shane-tomlinson · 2016-12-19T14:27:30Z

@shane-tomlinson on a 'tablet' resolution I noticed that the modal gets the 100% width:
not sure if we need to change any of that...

What is the resolution? It looks like it's hitting the "@media (max-width: 520px), (orientation: landscape) and (min-width: 481px) and (max-height: 480px) {" media query which is meant for mobile phones in landscape mode, that's how the @include repond-to('small') mixin works.

I'm not sure what the best approach here is. I'm tempted to say "that's fine for mobile." Throwing this PR up on stomlinson.dev.lcip.org to try on my iPad 2 to see how it responds on a real tablet in landscape mode.

This is an extraction from #4370 to make both simpler to review. For that PR, we need to be able to configure which app store logos are displayed to the user. This allows us to do so. The marketing-mixin module, instead of returning a mixin, returns a function that must be called with configuration options, the function returns the actual mixin. The marketing_snippet module allows two additional configuration options: * `marketingId` is the id used to log impressions and clicks * `which` forces specific logo(s) to be displayed. If not specified, uses default behavior. The Adjust links are extracted into Constants.js and shared between marketing_snippet.js and settings/clients.js. base.js->getSearchParam has been added to fetch a single search parameter. Add `isFirefoxAndroid`, `isFirefoxIos` and `isFirefoxDesktop` to user-agent.

@vladikoff

…#4519) r=@vladikoff This is an extraction from #4370 to make both simpler to review. For that PR, we need to be able to configure which app store logos are displayed to the user. This allows us to do so. The marketing-mixin module, instead of returning a mixin, returns a function that must be called with configuration options, the function returns the actual mixin. The marketing_snippet module allows two additional configuration options: * `marketingId` is the id used to log impressions and clicks * `which` forces specific logo(s) to be displayed. If not specified, uses default behavior. The Adjust links are extracted into Constants.js and shared between marketing_snippet.js and settings/clients.js. base.js->getSearchParam has been added to fetch a single search parameter. Add `isFirefoxAndroid`, `isFirefoxIos` and `isFirefoxDesktop` to user-agent.

@vladikoff

Allows users who open the verification link on a different Firefox to sign in, or if they open the link on the same device or a non-Firefox, show links to an app store to install. This is a squash of work done by both @vladikoff and I. fixes #4372

Only Fennec > 43 supports web channel Sync login.

A user is only eligible to see the "connect another device" screen if a different user is not already signed in. Log if users are already signed in.

Users that are signed in see "This device is connected" Users that are not signed in see "Email verified"

vladikoff · 2016-12-23T00:17:34Z

Nice! 👍

…ent. A lot of content was accidentally deleted in #4370, this brings back the content.

…ent. (#4593) r=vladikoff A lot of content was accidentally deleted in #4370, this brings back the content.

…ent. (mozilla#4593) r=vladikoff A lot of content was accidentally deleted in mozilla#4370, this brings back the content.

shane-tomlinson added WIP waffle:active labels Nov 3, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch from b02ac05 to 96bca69 Nov 3, 2016

shane-tomlinson changed the title ~~WIP feat(client): Send SMS~~ WIP feat(client): complete on fennec Nov 3, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch 3 times, most recently from 2dae1dc to 50d4736 Nov 3, 2016

vladikoff reviewed Nov 4, 2016

View changes

vladikoff force-pushed the shane-tomlinson/complete-on-fennec branch 2 times, most recently from b25a462 to 414f408 Nov 4, 2016

vladikoff mentioned this pull request Nov 4, 2016

Add the new Complete Sync setup page #4372

Closed

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch 3 times, most recently from e2b90b1 to a6b4318 Nov 6, 2016

vladikoff reviewed Nov 7, 2016

View changes

tests/functional/lib/helpers.js

assert.equal(resultText, expected);

})

.end();

.then(testAttributeEquals(selector, href, expected));

This comment has been minimized.

Sign in to view

vladikoff Nov 7, 2016
Contributor

👍 niiice

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch 3 times, most recently from f84ca31 to 5b1319d Nov 8, 2016

shane-tomlinson self-assigned this Nov 11, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch from 5b1319d to 048eca7 Nov 11, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch 2 times, most recently from 426f0fe to 41abd42 Nov 14, 2016

shane-tomlinson mentioned this pull request Nov 17, 2016

feat(client): Pass the email address in the resume token. #4422

Merged

shane-tomlinson added this to the FxA-51: Email Confirmation Flow (Phase 1) milestone Nov 17, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch from 41abd42 to 2a5369a Nov 17, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch from ebbe93e to 265a926 Dec 19, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch from 856ddd4 to 237fe44 Dec 20, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch from 237fe44 to a75a880 Dec 20, 2016

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch 4 times, most recently from 483b1fe to b0eb8ad Dec 21, 2016

Shane Tomlinson added 5 commits Nov 2, 2016

feat(client): "connect another device"

e20ad21

Allows users who open the verification link on a different Firefox to sign in, or if they open the link on the same device or a non-Firefox, show links to an app store to install. This is a squash of work done by both @vladikoff and I. fixes #4372

fix(client): Updates based on @vladikoff's feedback, web channel check.

b7896d1

Only Fennec > 43 supports web channel Sync login.

fix(client): Only connect another device if another user not signed in.

09b886a

A user is only eligible to see the "connect another device" screen if a different user is not already signed in. Log if users are already signed in.

chore(client): Update connect another device text.

528f3ab

feat(client): Show a different success message depending on auth status.

6b3c4cd

Users that are signed in see "This device is connected" Users that are not signed in see "Email verified"

shane-tomlinson force-pushed the shane-tomlinson/complete-on-fennec branch from b0eb8ad to 6b3c4cd Dec 22, 2016

vladikoff removed the waffle:active label Dec 23, 2016

shane-tomlinson deleted the shane-tomlinson/complete-on-fennec branch Dec 23, 2016

shane-tomlinson pushed a commit that referenced this pull request Jan 6, 2017

fix(docs): Bring back the accidentally deleted client-metrics.md cont…

cdfbd7c

…ent. A lot of content was accidentally deleted in #4370, this brings back the content.

shane-tomlinson mentioned this pull request Jan 6, 2017

fix(docs): Bring back the accidentally deleted client-metrics.md content. #4593

Merged

shane-tomlinson pushed a commit that referenced this pull request Jan 6, 2017

fix(docs): Bring back the accidentally deleted client-metrics.md cont…

b810f19

…ent. A lot of content was accidentally deleted in #4370, this brings back the content.

shane-tomlinson pushed a commit that referenced this pull request Jan 6, 2017

fix(docs): Bring back the accidentally deleted client-metrics.md cont…

8c2233d

…ent. A lot of content was accidentally deleted in #4370, this brings back the content.

vladikoff added a commit that referenced this pull request Jan 6, 2017

fix(docs): Bring back the accidentally deleted client-metrics.md cont…

1114db8

…ent. (#4593) r=vladikoff A lot of content was accidentally deleted in #4370, this brings back the content.

mozilla / fxa-content-server Archived

WIP feat(client): complete on fennec #4370

WIP feat(client): complete on fennec #4370

shane-tomlinson commented Nov 3, 2016 •

edited by vladikoff

rfk commented Nov 3, 2016

shane-tomlinson commented Nov 3, 2016

This comment has been minimized.

This comment has been minimized.

vladikoff commented Nov 14, 2016

vladikoff commented Nov 17, 2016

shane-tomlinson commented Nov 17, 2016

shane-tomlinson commented Dec 19, 2016

vladikoff commented Dec 23, 2016

mozilla / fxa-content-server Archived

WIP feat(client): complete on fennec #4370

WIP feat(client): complete on fennec #4370

Conversation

shane-tomlinson commented Nov 3, 2016 • edited by vladikoff

rfk commented Nov 3, 2016

shane-tomlinson commented Nov 3, 2016

This comment has been minimized.

vladikoff Nov 4, 2016 Contributor

This comment has been minimized.

vladikoff Nov 7, 2016 Contributor

vladikoff commented Nov 14, 2016

vladikoff commented Nov 17, 2016

shane-tomlinson commented Nov 17, 2016

shane-tomlinson commented Dec 19, 2016

vladikoff commented Dec 23, 2016

shane-tomlinson commented Nov 3, 2016 •

edited by vladikoff

vladikoff Nov 4, 2016
Contributor

vladikoff Nov 7, 2016
Contributor